Issue 6220043: Converted AAClips SampleApp slide to GM:simpleaaclip

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6220043: Converted AAClips SampleApp slide to GM:simpleaaclip (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by robertphillips

Modified:
12 years, 6 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, junov1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This conversion went pretty smoothly. The only oddity is that I had to copy the SkBitmap created in paint_rgn so that the deferred drawing test would work.

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+213 lines, -276 lines)			Patch
A	gm/simpleaaclip.cpp	View	1 chunk	+209 lines, -0 lines	0 comments	Download
M	gyp/SampleApp.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/gm.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	samplecode/SampleAAClip2.cpp	View	1 chunk	+0 lines, -275 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

LGTM. Justin, is the paint_rgn issue a deferred canvas bug?

12 years, 6 months ago (2012-05-18 14:16:50 UTC) #2

committed as r4025

Expand All Messages | Collapse All Messages