Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1102)

Issue 6219047: Issue 2539: Redocument tweak (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by dak
Modified:
11 years, 10 months ago
Reviewers:
Keith, Trevor Daniels
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Issue 2539: Redocument tweak This adjusts the documentation of \tweak to take into account a) EventChord not intervening uncalled for (issue 2240) b) the ability to specify indirect grobs (issue 2540) The patch as reviewed includes that for issue 2540 on first submission as that has not yet been committed to master.

Patch Set 1 #

Patch Set 2 : Added Changes entry #

Patch Set 3 : Rebase to issue 2540 (regtests and display routines) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -79 lines) Patch
M Documentation/changes.tely View 1 2 chunks +20 lines, -9 lines 0 comments Download
M Documentation/learning/tweaks.itely View 8 chunks +40 lines, -23 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 7 chunks +33 lines, -31 lines 0 comments Download
M input/regression/display-lily-tests.ly View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A input/regression/grob-indirect-tweak.ly View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M lily/tweak-engraver.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +18 lines, -12 lines 0 comments Download
M scm/display-lily.scm View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Trevor Daniels
Documentation changes LGTM Trevor
11 years, 11 months ago (2012-05-20 20:04:33 UTC) #1
Keith
11 years, 11 months ago (2012-05-21 06:27:30 UTC) #2
All seems clear.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b