Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 6216057: Move state onto GrGLShaderBuilder: sampleCoords + complexCoord (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by TomH
Modified:
12 years, 4 months ago
Reviewers:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

1- and 2-point RadialGradient mappings need to write these, so we move them onto the state. Uglifies a lot of genStageCode, since what were two stack vars end up on an object. In the fairly short run, though, most (?) of those references ought to migrate into CustomStage objects.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -87 lines) Patch
M src/gpu/gl/GrGLProgram.cpp View 13 chunks +53 lines, -66 lines 2 comments Download
M src/gpu/gl/GrGLProgramStage.h View 2 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.cpp View 2 chunks +6 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 chunk +10 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
TomH
http://codereview.appspot.com/6216057/diff/1/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): http://codereview.appspot.com/6216057/diff/1/src/gpu/gl/GrGLProgram.cpp#newcode1300 src/gpu/gl/GrGLProgram.cpp:1300: GrGLShaderVar* radial2Params) { Effectively, fsCoordName was being used as ...
12 years, 4 months ago (2012-05-17 19:44:41 UTC) #1
bsalomon
On 2012/05/17 19:44:41, TomH wrote: > http://codereview.appspot.com/6216057/diff/1/src/gpu/gl/GrGLProgram.cpp > File src/gpu/gl/GrGLProgram.cpp (right): > > http://codereview.appspot.com/6216057/diff/1/src/gpu/gl/GrGLProgram.cpp#newcode1300 > ...
12 years, 4 months ago (2012-05-18 14:11:42 UTC) #2
TomH
12 years, 4 months ago (2012-05-18 14:58:06 UTC) #3
Committed as r3996.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b