Issue 6215074: code review 6215074: crypto/ecdsa: hashToInt() mishandles curves with BitLen...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6215074: code review 6215074: crypto/ecdsa: hashToInt() mishandles curves with BitLen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by b

Modified:
12 years, 9 months ago

Reviewers:
rsc, golang-dev

Visibility:
Public.

Description

crypto/ecdsa: hashToInt() mishandles curves with BitLen() % 8 > 0 hashToInt() should only calculate excess bit length when the hash length exceeds the curve length. Otherwise non-truncated hashes will be right shifted when they shouldn't be. Currently, this only impacts the P521 curve.

Patch Set 1 #

Patch Set 2 : diff -r 3ce27769ca65 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3ce27769ca65 https://code.google.com/p/go/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/crypto/ecdsa/ecdsa.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 9 months ago (2012-05-22 00:49:36 UTC) #1

rsc

Looks like Adam beat you by an hour or so? http://codereview.appspot.com/6219057/

12 years, 9 months ago (2012-05-22 02:35:10 UTC) #2

Hah! Excellent. On May 21, 2012, at 7:34 PM, Russ Cox <rsc@golang.org> wrote: > Looks ...

12 years, 9 months ago (2012-05-22 02:41:16 UTC) #3

*** Abandoned ***

Expand All Messages | Collapse All Messages