Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(870)

Issue 6214050: Free cached AA clip mask when create hard/stencil clip mask (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by robertphillips
Modified:
12 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Release the cached AA clip mask when a stencil clip is requested. Note that this only clears the current save/restore state's cached clip mask. Those higher up the stack remain unchanged. This CL also addresses a resource freeing issue. With the addition of the AACache, the GPU could hold on to scratch textures after the freeing of the texture cache. These two issues are somewhat related in that the cache clearing change hides the resource freeing issue so I wanted to fix the latter before it could be forgotten.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 chunk +9 lines, -0 lines 2 comments Download
M src/gpu/GrContext.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 7 months ago (2012-05-16 20:19:18 UTC) #1
bsalomon
LGTM http://codereview.appspot.com/6214050/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): http://codereview.appspot.com/6214050/diff/1/src/gpu/GrClipMaskManager.cpp#newcode130 src/gpu/GrClipMaskManager.cpp:130: // AA cache. This comment refers to a ...
12 years, 7 months ago (2012-05-17 00:13:49 UTC) #2
robertphillips
12 years, 7 months ago (2012-05-17 12:01:27 UTC) #3
committed as r3983

http://codereview.appspot.com/6214050/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

http://codereview.appspot.com/6214050/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:130: // AA cache.
Correct - the utility draws will clear the cache when we may not want them to. I
hope to add a system to the cache that will store the clip stacks and detect
unnecessary cache misses.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b