On 2012/05/23 14:49:32, Jin Yang wrote: > fix one nit LGTM. I won't land it ...
12 years, 6 months ago
(2012-05-23 19:22:32 UTC)
#3
On 2012/05/23 14:49:32, Jin Yang wrote:
> fix one nit
LGTM. I won't land it right away because I'll have to make a chromium change
(chromium has its own GrGLInterface setup).
On 2012/05/23 19:22:32, bsalomon wrote: > On 2012/05/23 14:49:32, Jin Yang wrote: > > fix ...
12 years, 6 months ago
(2012-05-31 06:25:40 UTC)
#4
On 2012/05/23 19:22:32, bsalomon wrote:
> On 2012/05/23 14:49:32, Jin Yang wrote:
> > fix one nit
>
> LGTM. I won't land it right away because I'll have to make a chromium change
> (chromium has its own GrGLInterface setup).
Hi Brain,
The skia part should be firstly merged because chromium skia gl binding uses the
GrGLInterface structure. Is that right?
On 2012/05/31 06:25:40, Jin Yang wrote: > On 2012/05/23 19:22:32, bsalomon wrote: > > On ...
12 years, 6 months ago
(2012-05-31 12:23:33 UTC)
#5
On 2012/05/31 06:25:40, Jin Yang wrote:
> On 2012/05/23 19:22:32, bsalomon wrote:
> > On 2012/05/23 14:49:32, Jin Yang wrote:
> > > fix one nit
> >
> > LGTM. I won't land it right away because I'll have to make a chromium change
> > (chromium has its own GrGLInterface setup).
>
> Hi Brain,
> The skia part should be firstly merged because chromium skia gl binding uses
the
> GrGLInterface structure. Is that right?
Yes, I'm just holding off to land it until I have another checkin that also
requires updating Chromium (just to avoid having to make multiple changes to
Chromium). Should happen today or tomorrow.
On 2012/05/31 12:23:33, bsalomon wrote: > On 2012/05/31 06:25:40, Jin Yang wrote: > > On ...
12 years, 6 months ago
(2012-05-31 17:59:54 UTC)
#6
On 2012/05/31 12:23:33, bsalomon wrote:
> On 2012/05/31 06:25:40, Jin Yang wrote:
> > On 2012/05/23 19:22:32, bsalomon wrote:
> > > On 2012/05/23 14:49:32, Jin Yang wrote:
> > > > fix one nit
> > >
> > > LGTM. I won't land it right away because I'll have to make a chromium
change
> > > (chromium has its own GrGLInterface setup).
> >
> > Hi Brain,
> > The skia part should be firstly merged because chromium skia gl binding uses
> the
> > GrGLInterface structure. Is that right?
>
> Yes, I'm just holding off to land it until I have another checkin that also
> requires updating Chromium (just to avoid having to make multiple changes to
> Chromium). Should happen today or tomorrow.
Committed as r4099.
On 2012/05/31 17:59:54, bsalomon wrote: > On 2012/05/31 12:23:33, bsalomon wrote: > > On 2012/05/31 ...
12 years, 6 months ago
(2012-06-01 01:09:16 UTC)
#7
On 2012/05/31 17:59:54, bsalomon wrote:
> On 2012/05/31 12:23:33, bsalomon wrote:
> > On 2012/05/31 06:25:40, Jin Yang wrote:
> > > On 2012/05/23 19:22:32, bsalomon wrote:
> > > > On 2012/05/23 14:49:32, Jin Yang wrote:
> > > > > fix one nit
> > > >
> > > > LGTM. I won't land it right away because I'll have to make a chromium
> change
> > > > (chromium has its own GrGLInterface setup).
> > >
> > > Hi Brain,
> > > The skia part should be firstly merged because chromium skia gl binding
uses
> > the
> > > GrGLInterface structure. Is that right?
> >
> > Yes, I'm just holding off to land it until I have another checkin that also
> > requires updating Chromium (just to avoid having to make multiple changes to
> > Chromium). Should happen today or tomorrow.
>
> Committed as r4099.
Thanks!
Issue 6213069: Add glTexParameteriv to GL interface
(Closed)
Created 12 years, 6 months ago by Jin Yang
Modified 12 years, 6 months ago
Reviewers: bsalomon
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0