Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1688)

Issue 6213069: Add glTexParameteriv to GL interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by Jin Yang
Modified:
12 years, 5 months ago
Reviewers:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Withe this api, we can merge the 4 api calls into one for texture swizzle setting.

Patch Set 1 #

Patch Set 2 : fix one nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
include/gpu/gl/GrGLFunctions.h View 1 chunk +1 line, -0 lines 0 comments Download
include/gpu/gl/GrGLInterface.h View 1 1 chunk +1 line, -0 lines 0 comments Download
src/gpu/android/GrGLCreateNativeInterface_android.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/gpu/gl/GrGLCreateNullInterface.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
src/gpu/gl/GrGLInterface.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/gpu/gl/GrGpuGL.cpp View 1 chunk +3 lines, -13 lines 0 comments Download
src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/gpu/ios/GrGLDefaultInterface_iOS.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
Jin Yang
12 years, 5 months ago (2012-05-23 14:44:23 UTC) #1
Jin Yang
fix one nit
12 years, 5 months ago (2012-05-23 14:49:32 UTC) #2
bsalomon
On 2012/05/23 14:49:32, Jin Yang wrote: > fix one nit LGTM. I won't land it ...
12 years, 5 months ago (2012-05-23 19:22:32 UTC) #3
Jin Yang
On 2012/05/23 19:22:32, bsalomon wrote: > On 2012/05/23 14:49:32, Jin Yang wrote: > > fix ...
12 years, 5 months ago (2012-05-31 06:25:40 UTC) #4
bsalomon
On 2012/05/31 06:25:40, Jin Yang wrote: > On 2012/05/23 19:22:32, bsalomon wrote: > > On ...
12 years, 5 months ago (2012-05-31 12:23:33 UTC) #5
bsalomon
On 2012/05/31 12:23:33, bsalomon wrote: > On 2012/05/31 06:25:40, Jin Yang wrote: > > On ...
12 years, 5 months ago (2012-05-31 17:59:54 UTC) #6
Jin Yang
12 years, 5 months ago (2012-06-01 01:09:16 UTC) #7
On 2012/05/31 17:59:54, bsalomon wrote:
> On 2012/05/31 12:23:33, bsalomon wrote:
> > On 2012/05/31 06:25:40, Jin Yang wrote:
> > > On 2012/05/23 19:22:32, bsalomon wrote:
> > > > On 2012/05/23 14:49:32, Jin Yang wrote:
> > > > > fix one nit
> > > > 
> > > > LGTM. I won't land it right away because I'll have to make a chromium
> change
> > > > (chromium has its own GrGLInterface setup).
> > > 
> > > Hi Brain,
> > > The skia part should be firstly merged because chromium skia gl binding
uses
> > the
> > > GrGLInterface structure. Is that right?
> > 
> > Yes, I'm just holding off to land it until I have another checkin that also
> > requires updating Chromium (just to avoid having to make multiple changes to
> > Chromium). Should happen today or tomorrow.
> 
> Committed as r4099.

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b