Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(172)

Issue 6211083: Updated useSWOnlyPath method to use path chain instead of raw path renderer methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by robertphillips
Modified:
12 years, 5 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL re-encapsulates the path renderers. I have verified that the useSWOnlyPath function still only enables the SW-only path on the complexclip_aa GM slide.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed conversion of rect to path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -73 lines) Patch
M src/gpu/GrAAConvexPathRenderer.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 1 chunk +5 lines, -12 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 chunks +4 lines, -11 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 3 chunks +34 lines, -40 lines 0 comments Download

Messages

Total messages: 7
robertphillips
http://codereview.appspot.com/6211083/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): http://codereview.appspot.com/6211083/diff/1/src/gpu/GrClipMaskManager.cpp#newcode112 src/gpu/GrClipMaskManager.cpp:112: // block could disappear What is your opinion on ...
12 years, 5 months ago (2012-05-23 13:55:02 UTC) #1
bsalomon
http://codereview.appspot.com/6211083/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): http://codereview.appspot.com/6211083/diff/1/src/gpu/GrClipMaskManager.cpp#newcode112 src/gpu/GrClipMaskManager.cpp:112: // block could disappear On 2012/05/23 13:55:03, robertphillips wrote: ...
12 years, 5 months ago (2012-05-23 15:01:20 UTC) #2
robertphillips
Wouldn't this basically just entail moving GrContext::fillAARect to GrDrawTarget?
12 years, 5 months ago (2012-05-23 15:34:45 UTC) #3
bsalomon
On 2012/05/23 15:34:45, robertphillips wrote: > Wouldn't this basically just entail moving GrContext::fillAARect to > ...
12 years, 5 months ago (2012-05-23 15:37:25 UTC) #4
robertphillips
http://codereview.appspot.com/6211083/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): http://codereview.appspot.com/6211083/diff/1/src/gpu/GrClipMaskManager.cpp#newcode112 src/gpu/GrClipMaskManager.cpp:112: // block could disappear On 2012/05/23 15:01:20, bsalomon wrote: ...
12 years, 5 months ago (2012-05-24 11:54:38 UTC) #5
bsalomon
On 2012/05/24 11:54:38, robertphillips wrote: > http://codereview.appspot.com/6211083/diff/1/src/gpu/GrClipMaskManager.cpp > File src/gpu/GrClipMaskManager.cpp (right): > > http://codereview.appspot.com/6211083/diff/1/src/gpu/GrClipMaskManager.cpp#newcode112 > ...
12 years, 5 months ago (2012-05-24 12:37:39 UTC) #6
robertphillips
12 years, 5 months ago (2012-05-24 12:43:01 UTC) #7
Received verbal LGTM from Brian

committed as r4038
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b