Convert AAClipCache's GrRects to GrIRects

This change makes explicit that the clip mask bounds are integerized.

[bsalomon, 2012-05-14 22:17:57]

LGTM. Adding Mike just in case he cares about overloading SkRect::contains(const
SkRect&) cosnt and SkRect::contains(const SkIRect&) const

[reed1, 2012-05-15 12:31:01]

While they're not incorrect, I'm not enthusiastic for the new apis added to
SkRect.  

Its minor, but outset() kind of makes me think that inset() isn't really capable
of + and - values (and if have have positive dx and negative dy, which api
should I call?)

The new contains is correct, but inefficient since it has to convert ints to
floats, which I might prefer that the caller is made aware that this guy is
slower than the int version. Also, should we have SkIRect::contains(SkRect)  for
completeness? I'm a little wary of expanding method apis to cover the
cross-product of the other related classes.

All that said, nothing is bad either. Can we place these two closer to the new
call sites as local helpers, and see how we like them over time?

[robertphillips, 2012-05-15 13:36:07]

After discussing with Mike, this delivery moves SkRect::contains(SkIRect) out of
SkRect and into GrClipMaskManager. I left outset in SkIRect to make its
interface better match SkRect's.

[bsalomon, 2012-05-15 14:36:04]

On 2012/05/15 13:36:07, robertphillips wrote:
> After discussing with Mike, this delivery moves SkRect::contains(SkIRect) out
of
> SkRect and into GrClipMaskManager. I left outset in SkIRect to make its
> interface better match SkRect's.

Aside: my argument for outset is that we (or at least I) do it more often than
inset and its just easier to read outset(1, 1) than inset(-1, -1) in the same
way that it's easier to read "if (enabled)" over "if (!disabled)".

[reed1, 2012-05-15 14:39:48]

kinda sorta agree.

what about

inset(-1, 1) -vs- outset(1, -1)

having both means having to remember two notions instead of one :)

[bsalomon, 2012-05-15 14:48:30]

touché

On Tue, May 15, 2012 at 7:39 AM, <reed@google.com> wrote:

> kinda sorta agree.
>
> what about
>
> inset(-1, 1) -vs- outset(1, -1)
>
> having both means having to remember two notions instead of one :)
>
>
http://codereview.appspot.com/**6210057/<http://codereview.appspot.com/6210057/>
>

[robertphillips, 2012-05-15 16:49:47]

committed as r3942