Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(788)

Issue 6210044: Make clip mask cache use Scratch Texture system (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by robertphillips
Modified:
12 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Plumbing in the scratch texture system required a bit of reshuffling of the cache's texture acquisition system. I also had to make changes since we can now get textures larger than expected.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -107 lines) Patch
M include/gpu/GrContext.h View 1 chunk +1 line, -0 lines 1 comment Download
M src/gpu/GrClipMaskManager.h View 14 chunks +64 lines, -35 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 15 chunks +41 lines, -53 lines 4 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrGpu.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/ClipCacheTest.cpp View 5 chunks +34 lines, -15 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 7 months ago (2012-05-11 20:45:17 UTC) #1
bsalomon
LGTM http://codereview.appspot.com/6210044/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): http://codereview.appspot.com/6210044/diff/1/include/gpu/GrContext.h#newcode856 include/gpu/GrContext.h:856: fEntry.reset(); nice catch http://codereview.appspot.com/6210044/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): http://codereview.appspot.com/6210044/diff/1/src/gpu/GrClipMaskManager.cpp#newcode356 ...
12 years, 7 months ago (2012-05-11 21:14:06 UTC) #2
robertphillips
12 years, 7 months ago (2012-05-14 12:19:05 UTC) #3
committed as r3920

http://codereview.appspot.com/6210044/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

http://codereview.appspot.com/6210044/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:356: GrRect rect = GrRect::MakeLTRB(0, 0,
On 2012/05/11 21:14:06, bsalomon wrote:
> super-nit: there is a GrRecT::MakeWH that sets to top left to (0, 0)

Done.

http://codereview.appspot.com/6210044/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:411: kAlpha_8_GrPixelConfig,
I was hoping we could loosen up the scratch texture system so that it could
allocate an RGBA8 is no A8/R8 textures are available.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b