Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 6208077: code review 6208077: cmd/ld, cmd/5l, cmd/go: a workaound to support linking ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by minux1
Modified:
14 years ago
Reviewers:
rsc, golang-dev
CC:
golang-dev
Visibility:
Public.

Description

cmd/ld, cmd/5l, cmd/go: a workaround to support linking thumb library we pass -mlong-calls to gcc so that we don't need to worry about generating mode changing veneers. But, we still need to address this problem later. In preparation of CL 5822049. (Ubuntu uses a thumb libgcc, so without this CL, the new libgcc test in CL 5822049 will break the build)

Patch Set 1 #

Patch Set 2 : diff -r 0581aafd0aaf https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0581aafd0aaf https://code.google.com/p/go/ #

Patch Set 4 : diff -r 0581aafd0aaf https://code.google.com/p/go/ #

Patch Set 5 : diff -r 85e153815747 https://code.google.com/p/go/ #

Patch Set 6 : diff -r b54f4da6d7be https://code.google.com/p/go/ #

Patch Set 7 : diff -r 046668c6315e https://code.google.com/p/go/ #

Patch Set 8 : diff -r 046668c6315e https://code.google.com/p/go/ #

Patch Set 9 : diff -r 046668c6315e https://code.google.com/p/go/ #

Patch Set 10 : diff -r 046668c6315e https://code.google.com/p/go/ #

Patch Set 11 : diff -r 046668c6315e https://code.google.com/p/go/ #

Patch Set 12 : diff -r 046668c6315e https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M src/cmd/5l/5.out.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5l/asm.c View 1 2 3 4 5 6 7 8 8 chunks +28 lines, -6 lines 0 comments Download
M src/cmd/go/build.go View 1 7 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/ldelf.c View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 2
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
14 years ago (2012-05-22 19:53:45 UTC) #1
rsc
14 years ago (2012-05-29 17:01:25 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b