Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)

Issue 6208055: Debug Windows compiler complaint fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This delivery fixes all the remaining Debug Windows compiler complaints. There are still ~5 Release-only complaints.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -46 lines) Patch
M bench/InterpBench.cpp View 1 chunk +15 lines, -4 lines 2 comments Download
M gyp/gpu.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M samplecode/SampleRegion.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
D src/gpu/gl/debug/GrFBBindableObj.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
D src/gpu/gl/debug/GrRenderBufferObj.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/pdf/SkPDFDocument.cpp View 1 chunk +1 line, -1 line 1 comment Download
M tests/DrawBitmapRectTest.cpp View 2 chunks +14 lines, -6 lines 0 comments Download
M tests/MathTest.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 2 chunks +3 lines, -5 lines 1 comment Download
M tests/ToUnicode.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6
robertphillips
http://codereview.appspot.com/6208055/diff/1/tests/PDFPrimitivesTest.cpp File tests/PDFPrimitivesTest.cpp (left): http://codereview.appspot.com/6208055/diff/1/tests/PDFPrimitivesTest.cpp#oldcode10 tests/PDFPrimitivesTest.cpp:10: #include <string> This causes complaints r.e. exception handling and ...
12 years, 4 months ago (2012-05-14 13:40:53 UTC) #1
TomH
Modulo PDF-nit, LGTM. http://codereview.appspot.com/6208055/diff/1/bench/InterpBench.cpp File bench/InterpBench.cpp (right): http://codereview.appspot.com/6208055/diff/1/bench/InterpBench.cpp#newcode88 bench/InterpBench.cpp:88: curr += step; This is now ...
12 years, 4 months ago (2012-05-14 13:45:44 UTC) #2
robertphillips
Added vandebo@ to assess the PDF file changes. http://codereview.appspot.com/6208055/diff/1/bench/InterpBench.cpp File bench/InterpBench.cpp (right): http://codereview.appspot.com/6208055/diff/1/bench/InterpBench.cpp#newcode88 bench/InterpBench.cpp:88: curr ...
12 years, 4 months ago (2012-05-14 14:05:09 UTC) #3
reed1
The 80-col rule was made for man, not man for the 80-col rule...
12 years, 4 months ago (2012-05-14 15:22:04 UTC) #4
Steve VanDeBogart
LGTM
12 years, 4 months ago (2012-05-14 16:19:19 UTC) #5
robertphillips
12 years, 4 months ago (2012-05-14 16:34:04 UTC) #6
committed as r3924
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b