Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1204)

Issue 62071: DiagonalCoeffs-->Band

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by bjacob
Modified:
9 years, 4 months ago
Reviewers:
Base URL:
http://websvn.kde.org/*checkout*/trunk/kdesupport/eigen2
Visibility:
Public.

Description

* rename DiagonalCoeffs (clumsy name) to Band. I tried first Diagonal, but that name was already taken by a constant Diagonal which is used for various things already. * rename the template parameter DiagId to Index. * keep diagonal() unchanged, returns a Band<Derived, 0> * rename diagonal<int>() to band<int>() * introduce diagonal(int), returning a Band<Derived, Dynamic>. The trick here is as we already do in Block : use ei_int_if_dynamic to store the Index in Band. ---> that is the improvement that i need in order to code BandedMatrix. No need to unroll an outer loop there, and that also will reduce compilation times (only one Band type instantiated).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -247 lines) Patch
Eigen/Core View 1 chunk +1 line, -1 line 0 comments Download
Eigen/src/Cholesky/LDLT.h View 1 chunk +1 line, -1 line 0 comments Download
Eigen/src/Core/Band.h View 2 chunks +77 lines, -50 lines 0 comments Download
Eigen/src/Core/DiagonalCoeffs.h View 1 chunk +0 lines, -159 lines 0 comments Download
Eigen/src/Core/MatrixBase.h View 2 chunks +12 lines, -6 lines 0 comments Download
Eigen/src/Core/Transpose.h View 1 chunk +1 line, -1 line 0 comments Download
Eigen/src/Core/util/Constants.h View 2 chunks +2 lines, -4 lines 0 comments Download
Eigen/src/Core/util/ForwardDeclarations.h View 1 chunk +1 line, -1 line 0 comments Download
Eigen/src/LU/LU.h View 2 chunks +2 lines, -2 lines 0 comments Download
Eigen/src/QR/HessenbergDecomposition.h View 1 chunk +3 lines, -3 lines 0 comments Download
Eigen/src/QR/Tridiagonalization.h View 1 chunk +3 lines, -3 lines 0 comments Download
Eigen/src/Sparse/SparseMatrixBase.h View 1 chunk +2 lines, -2 lines 0 comments Download
doc/snippets/MatrixBase_band_int.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
doc/snippets/MatrixBase_diagonal_int.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
test/submatrices.cpp View 2 chunks +14 lines, -7 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b