Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(472)

Issue 6206071: CG tweak: some extra info on make doc and doc build times.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Joseph Rushton Wakeling
Modified:
11 years, 10 months ago
Reviewers:
Graham Percival, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

CG tweak: some extra info on make doc and doc build times.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add doc build info via link to in-depth section #

Total comments: 1

Patch Set 3 : Tweak remarks on doc build time in line with Graham's request #

Patch Set 4 : Use a @warning{} to highlight the possible length of build time #

Patch Set 5 : Use a @warning{} to highlight the possible length of build time #

Patch Set 6 : Updates to CG with extra info on make doc and doc build times #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M Documentation/included/compile.itexi View 1 2 3 3 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 13
Joseph Rushton Wakeling
As per earlier discussion on devel list, this patch just adds a little bit of ...
11 years, 10 months ago (2012-05-15 22:26:16 UTC) #1
Graham Percival
http://codereview.appspot.com/6206071/diff/1/Documentation/included/compile.itexi File Documentation/included/compile.itexi (right): http://codereview.appspot.com/6206071/diff/1/Documentation/included/compile.itexi#newcode464 Documentation/included/compile.itexi:464: or to build only the PDF documentation, Don't we ...
11 years, 10 months ago (2012-05-16 12:05:19 UTC) #2
Joseph Rushton Wakeling
On 2012/05/16 12:05:19, Graham Percival wrote: > Don't we have a different place that discusses ...
11 years, 10 months ago (2012-05-16 14:26:29 UTC) #3
Joseph Rushton Wakeling
Latest patches update as suggested The build section has a link to 4.6.2 and I've ...
11 years, 10 months ago (2012-05-30 10:11:12 UTC) #4
Graham Percival
https://codereview.appspot.com/6206071/diff/6001/Documentation/included/compile.itexi File Documentation/included/compile.itexi (right): https://codereview.appspot.com/6206071/diff/6001/Documentation/included/compile.itexi#newcode646 Documentation/included/compile.itexi:646: easily take an hour or more, so don't panic ...
11 years, 10 months ago (2012-05-30 16:55:17 UTC) #5
Joseph Rushton Wakeling
On 2012/05/30 16:55:17, Graham Percival wrote: > I'm not convinced that the added text will ...
11 years, 10 months ago (2012-05-30 19:24:08 UTC) #6
Graham Percival
ok. The @warning{} suggestion was aimed at making it much more visible, but if you ...
11 years, 10 months ago (2012-05-30 21:16:09 UTC) #7
Joseph Rushton Wakeling
On 2012/05/30 21:16:09, Graham Percival wrote: > The @warning{} ... I'm blind. Give me 2 ...
11 years, 10 months ago (2012-05-30 21:17:57 UTC) #8
Graham Percival
oh, and since you didn't use our custom git-cl to upload this patch, you'll need ...
11 years, 10 months ago (2012-05-30 21:18:57 UTC) #9
Joseph Rushton Wakeling
I have always been using git-cl but for all patches after the first I got ...
11 years, 10 months ago (2012-05-30 21:45:58 UTC) #10
dak
[copy of message posted to devel list] On 2012/05/30 21:45:58, Joseph Rushton Wakeling wrote: > ...
11 years, 10 months ago (2012-05-31 00:01:55 UTC) #11
Joseph Rushton Wakeling
On 2012/05/31 00:01:55, dak wrote: > That's not the Google tracker issue number, but the ...
11 years, 10 months ago (2012-05-31 11:03:36 UTC) #12
Graham Percival
11 years, 10 months ago (2012-05-31 14:30:44 UTC) #13
LGTM, it can be pushed directly to staging.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b