Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3396)

Issue 6206060: Fix ukulele tunings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by choan.galvez
Modified:
11 years, 10 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Fix ukulele tunings Reverse the order of the chord for the tenor-ukulele-tuning and baritone-ukulele-tuning

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ly/string-tunings-init.ly View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
choan.galvez
tenor-ukulele-tuning and baritone-ukulele-tuning fixed, the string order was reversed.
11 years, 11 months ago (2012-05-13 02:29:54 UTC) #1
dak
On 2012/05/13 02:29:54, choan.galvez wrote: > tenor-ukulele-tuning and baritone-ukulele-tuning fixed, the string order was > ...
11 years, 11 months ago (2012-05-13 05:43:17 UTC) #2
dak
On 2012/05/13 05:43:17, dak wrote: > On 2012/05/13 02:29:54, choan.galvez wrote: > > tenor-ukulele-tuning and ...
11 years, 10 months ago (2012-06-23 16:09:54 UTC) #3
choan.galvez
11 years, 10 months ago (2012-06-23 16:22:27 UTC) #4
On 6/23/12 18:09 , dak@gnu.org wrote:
> On 2012/05/13 05:43:17, dak wrote:
>> On 2012/05/13 02:29:54, choan.galvez wrote:
>> > tenor-ukulele-tuning and baritone-ukulele-tuning fixed, the string
> order was
>> > reversed.
>
>> In the user group, a more extensive change was/is discussed that could
> also be
>> worthwhile.  This patch here, in contrast, is just a bug fix.  As
> such, applying
>> it is a no-brainer.  I'd push it to staging right after it passes the
> standard
>> test (and I should be rather shocked if it did not).
>
> This has been pushed as
> commit 820ff91cbd911d9728ac91ff52617876c790d757
> Author: Choan Gálvez <choan.galvez@gmail.com>
> Date:   Sun May 13 09:51:18 2012 +0200
>
>      Issue 2531: Fix ukulele tunings
>
>      Reverse the order of the chord for the tenor-ukulele-tuning and
>      baritone-ukulele-tuning
>
>      Signed-off-by: David Kastrup <dak@gnu.org>
>
> and you might want to close the Rietveld issue.
>
> http://codereview.appspot.com/6206060/

Done. I wasn't aware that it was me who should close it.

Best.
-- 
Choan Gálvez
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b