Adding .classpath and putting jars under libs and *-sources.jars under libs-sources.

Fix for http://code.google.com/p/google-http-java-client/issues/detail?id=109 : New structure for jars in zip package.

[yanivi, 2012-05-11 16:56:49]

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/....
File google-http-client-assembly/.classpath (right):

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/....
google-http-client-assembly/.classpath:1: <?xml version="1.0" encoding="UTF-8"?>
since this is not a full .classpath file and only a snippet to be copied into
user's .classpath, perhaps we should remove lines 1, 2, and 15

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/....
google-http-client-assembly/.classpath:3: <classpathentry kind="lib"
path="libs/google-http-client-${project.version}.jar"
sourcepath="libs-sources/google-http-client-${project.version}-sources.jar"/>
Eclipse seems to like tabs for .classpath files, so I recommend we switch to
tabs so users get a consistent indent style when copying into their own project.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/....
google-http-client-assembly/.classpath:4: <classpathentry kind="lib"
path="libs/google-http-client-android2-${project.version}.jar"
sourcepath="libs-sources/google-http-client-android2-${project.version}-sources.jar"/>
missing android3

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/a...
File google-http-client-assembly/assembly.xml (right):

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/a...
google-http-client-assembly/assembly.xml:27:
<directory>target/dependencies</directory>
please take a look at the google-http-client-assembly/pom.xml

I'd rather we just generate the binary jars into libs and the source jars into
libs-sources directly in there

it should simplify your life a bit

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
File google-http-client-assembly/readme.html (right):

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
google-http-client-assembly/readme.html:15: <h3>Library Details</h3>
since we are specifying non-Maven usage, do you want to summarize Maven usage
also:

    <dependency>
      <groupId>com.google.http-client</groupId>
      <artifactId>google-http-client</artifactId>
      <version>1.8.3-beta</version>
    </dependency>

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
google-http-client-assembly/readme.html:28: <li>google-http-client: <a
href='dependencies-html/dependencies.html'>dependencies.html</a></li>
[optional] why change it?  I slightly prefer "dependencies" over
"dependencies-html"

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
google-http-client-assembly/readme.html:34: <h3>.classpath</h3>
Better to use the title Eclipse.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
google-http-client-assembly/readme.html:35: A .classpath file has been provided
with the required dependencies <a href='.classpath'>here</a>.
specify that this is a snippet of the .classpath to be included in your
project's .classpath, since a real project will need other things in the
.classpath

and also of course that they should only use the classpathentry's they actually
need (see below for details).

[rmistry, 2012-05-14 14:11:17]

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/....
File google-http-client-assembly/.classpath (right):

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/....
google-http-client-assembly/.classpath:1: <?xml version="1.0" encoding="UTF-8"?>
On 2012/05/11 16:56:49, yanivi wrote:
> since this is not a full .classpath file and only a snippet to be copied into
> user's .classpath, perhaps we should remove lines 1, 2, and 15

Done.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/....
google-http-client-assembly/.classpath:3: <classpathentry kind="lib"
path="libs/google-http-client-${project.version}.jar"
sourcepath="libs-sources/google-http-client-${project.version}-sources.jar"/>
On 2012/05/11 16:56:49, yanivi wrote:
> Eclipse seems to like tabs for .classpath files, so I recommend we switch to
> tabs so users get a consistent indent style when copying into their own
project.

Done.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/....
google-http-client-assembly/.classpath:4: <classpathentry kind="lib"
path="libs/google-http-client-android2-${project.version}.jar"
sourcepath="libs-sources/google-http-client-android2-${project.version}-sources.jar"/>
On 2012/05/11 16:56:49, yanivi wrote:
> missing android3

Oops. Done.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/a...
File google-http-client-assembly/assembly.xml (right):

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/a...
google-http-client-assembly/assembly.xml:27:
<directory>target/dependencies</directory>
On 2012/05/11 16:56:49, yanivi wrote:
> please take a look at the google-http-client-assembly/pom.xml
> 
> I'd rather we just generate the binary jars into libs and the source jars into
> libs-sources directly in there
> 
> it should simplify your life a bit

Yes, much better now.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
File google-http-client-assembly/readme.html (right):

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
google-http-client-assembly/readme.html:15: <h3>Library Details</h3>
On 2012/05/11 16:56:49, yanivi wrote:
> since we are specifying non-Maven usage, do you want to summarize Maven usage
> also:
> 
>     <dependency>
>       <groupId>com.google.http-client</groupId>
>       <artifactId>google-http-client</artifactId>
>       <version>1.8.3-beta</version>
>     </dependency>

Pointing users to
http://code.google.com/p/google-http-java-client/wiki/Setup#Maven instead. Done.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
google-http-client-assembly/readme.html:28: <li>google-http-client: <a
href='dependencies-html/dependencies.html'>dependencies.html</a></li>
On 2012/05/11 16:56:49, yanivi wrote:
> [optional] why change it?  I slightly prefer "dependencies" over
> "dependencies-html"

Either way is fine with me. Done.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
google-http-client-assembly/readme.html:34: <h3>.classpath</h3>
On 2012/05/11 16:56:49, yanivi wrote:
> Better to use the title Eclipse.

Done.

http://codereview.appspot.com/6203065/diff/2004/google-http-client-assembly/r...
google-http-client-assembly/readme.html:35: A .classpath file has been provided
with the required dependencies <a href='.classpath'>here</a>.
On 2012/05/11 16:56:49, yanivi wrote:
> specify that this is a snippet of the .classpath to be included in your
> project's .classpath, since a real project will need other things in the
> .classpath
> 
> and also of course that they should only use the classpathentry's they
actually
> need (see below for details).

Done.

[yanivi, 2012-05-14 14:43:01]

LGTM

http://codereview.appspot.com/6203065/diff/3003/google-http-client-assembly/r...
File google-http-client-assembly/readme.html (right):

http://codereview.appspot.com/6203065/diff/3003/google-http-client-assembly/r...
google-http-client-assembly/readme.html:25: Dependent jars can be found in the
<a href='libs'>libs</a> folder and the corresponding source jars can be found in
the <a href='libs-sources'>libs-sources</a> folder<br/><br/>
period at the end of this sentence.

http://codereview.appspot.com/6203065/diff/3003/google-http-client-assembly/r...
google-http-client-assembly/readme.html:35: For information on how to add these
libraries to your maven project please see
capitalize Maven

http://codereview.appspot.com/6203065/diff/3003/google-http-client-assembly/r...
google-http-client-assembly/readme.html:59: folder required for Google App
Engine applications or a newer compatible version:
please add a link to
http://code.google.com/p/google-http-java-client/wiki/GoogleAppEngine just like
we do for Android

[rmistry, 2012-05-14 14:55:36]

http://codereview.appspot.com/6203065/diff/3003/google-http-client-assembly/r...
File google-http-client-assembly/readme.html (right):

http://codereview.appspot.com/6203065/diff/3003/google-http-client-assembly/r...
google-http-client-assembly/readme.html:25: Dependent jars can be found in the
<a href='libs'>libs</a> folder and the corresponding source jars can be found in
the <a href='libs-sources'>libs-sources</a> folder<br/><br/>
On 2012/05/14 14:43:01, yanivi wrote:
> period at the end of this sentence.

Done.

http://codereview.appspot.com/6203065/diff/3003/google-http-client-assembly/r...
google-http-client-assembly/readme.html:35: For information on how to add these
libraries to your maven project please see
On 2012/05/14 14:43:01, yanivi wrote:
> capitalize Maven

Done.

http://codereview.appspot.com/6203065/diff/3003/google-http-client-assembly/r...
google-http-client-assembly/readme.html:59: folder required for Google App
Engine applications or a newer compatible version:
On 2012/05/14 14:43:01, yanivi wrote:
> please add a link to
> http://code.google.com/p/google-http-java-client/wiki/GoogleAppEngine just
like
> we do for Android

Done.