Issue 6203056: Fix a number of display-lily shortcomings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6203056: Fix a number of display-lily shortcomings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by dak

Modified:
11 years, 11 months ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Fix a number of display-lily shortcomings Several postevents including non-shorthand articulations were printed with redundant direction flag - , command events on single note events were missing the required direction flag - , and a few other problems. As far as I can tell, none of these changes would count as a regression, but some are definitely to be considered bugs.

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -22 lines)			Patch
	M	input/regression/display-lily-tests.ly	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	scm/define-music-display-methods.scm	View		4 chunks	+24 lines, -17 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Neil Puttock

11 years, 11 months ago (2012-05-09 16:40:39 UTC) #1

LGTM.

Just some redundant spaces in the ArticulationEvent display method needs
removing, but then they were already there.

Cheers,
Neil

Expand All Messages | Collapse All Messages