Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6705)

Issue 6203044: Make \footnote a post-event (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by dak
Modified:
11 years, 11 months ago
Reviewers:
Keith, Graham Percival
CC:
lilypond-devel_gnu.org, Keith
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Make \footnote a post-event Also run scripts/auxiliar/update-with-convert-ly.sh The result should work, but for sanity's sake, this should be followed by a manual conversion of all occurences of <>\footnote ... note-or-chord into note-or-chord\footnote ... It would have been too error-prone to try detecting a suitable note-or-chord sequence to move across automatically.

Patch Set 1 #

Patch Set 2 : Fix version numbering typo #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -175 lines) Patch
M Documentation/de/notation/input.itely View 1 7 chunks +25 lines, -25 lines 0 comments Download
M Documentation/es/notation/input.itely View 1 7 chunks +25 lines, -25 lines 0 comments Download
M Documentation/fr/notation/input.itely View 1 7 chunks +25 lines, -25 lines 0 comments Download
M Documentation/ja/notation/input.itely View 1 7 chunks +25 lines, -25 lines 0 comments Download
M Documentation/notation/input.itely View 1 7 chunks +25 lines, -25 lines 0 comments Download
M input/regression/collision-seconds.ly View 1 chunk +1 line, -1 line 2 comments Download
M input/regression/footnote.ly View 1 3 chunks +5 lines, -5 lines 0 comments Download
M input/regression/footnote-auto-numbering.ly View 1 3 chunks +5 lines, -5 lines 0 comments Download
M input/regression/footnote-auto-numbering-page-reset.ly View 1 3 chunks +5 lines, -5 lines 0 comments Download
M input/regression/footnote-auto-numbering-vertical-order.ly View 1 3 chunks +19 lines, -19 lines 0 comments Download
M input/regression/footnote-break-visibility.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/footnote-footer-padding.ly View 1 2 chunks +4 lines, -4 lines 0 comments Download
M input/regression/footnote-spanner.ly View 1 3 chunks +3 lines, -3 lines 0 comments Download
M input/regression/in-note.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +1 line, -1 line 0 comments Download
M python/convertrules.py View 1 1 chunk +19 lines, -0 lines 0 comments Download
M scm/define-music-types.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Keith
I like the way you showed the results of the convert-ly regexp on the docs. ...
11 years, 11 months ago (2012-05-10 06:53:33 UTC) #1
Graham Percival
LGTM
11 years, 11 months ago (2012-05-10 13:16:10 UTC) #2
dak
11 years, 11 months ago (2012-05-14 14:57:29 UTC) #3
As you can see, this draft comment did not get out in time but was forgotten.

Looks like changing the version to 2.15.34 is now in your ballpark.

http://codereview.appspot.com/6203044/diff/1018/input/regression/collision-se...
File input/regression/collision-seconds.ly (right):

http://codereview.appspot.com/6203044/diff/1018/input/regression/collision-se...
input/regression/collision-seconds.ly:1: \version "2.14.0"
On 2012/05/10 06:53:33, Keith wrote:
> convert-ly changed this because I mis-typed an older version number when
> expanding this test.  I'll change it later to "2.15.34" unless you do it with
> this commit.

Sounds rather like something you should directly push to staging.  I'll catch up
with it when rebasing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b