Issue 6202053: move more stuff that should be private out from GrGLConfig.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6202053: move more stuff that should be private out from GrGLConfig.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by bsalomon

Modified:
12 years, 4 months ago

Reviewers:
robertphilips, robertphillips, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : sadjfh #

Total comments: 1

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -98 lines)			Patch
M	include/gpu/gl/GrGLConfig.h	View		1 chunk	+0 lines, -85 lines	0 comments	Download
M	include/gpu/gl/GrGLInterface.h	View		1 chunk	+0 lines, -4 lines	1 comment	Download
M	src/gpu/GrDefaultTextContext.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLUtil.h	View		1 chunk	+73 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGpuGLShaders.cpp	View	1	3 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

http://codereview.appspot.com/6202053/diff/2001/include/gpu/gl/GrGLInterface.h File include/gpu/gl/GrGLInterface.h (left): http://codereview.appspot.com/6202053/diff/2001/include/gpu/gl/GrGLInterface.h#oldcode16 include/gpu/gl/GrGLInterface.h:16: #if !defined(GR_GL_FUNCTION_TYPE) This is in the wrong place and ...

12 years, 4 months ago (2012-05-07 18:28:12 UTC) #1

Closed, r3856.

Expand All Messages | Collapse All Messages