Move coordDims, varyingDims onto GrGLShaderBuilder

In order to emit varying parameters, we'll need to know their dimensionality.

When Montreal does the Look-Up Table implementation fCoordDims may become non-constant, but this implementation is no worse than what we have now.

[robertphillips, 2012-05-14 18:49:52]

LGTM + 1 suggestion

http://codereview.appspot.com/6201083/diff/2001/src/gpu/gl/GrGLShaderBuilder.cpp
File src/gpu/gl/GrGLShaderBuilder.cpp (right):

http://codereview.appspot.com/6201083/diff/2001/src/gpu/gl/GrGLShaderBuilder....
src/gpu/gl/GrGLShaderBuilder.cpp:23: const int GrGLShaderBuilder::fCoordDims =
2;
Could we move this into the header?

[bsalomon, 2012-05-14 19:13:41]

Could the incoming coords be a grglshadervar? (Maybe a dumb q, writing from
my phone while eating lunch)
On May 14, 2012 11:49 AM, <robertphillips@google.com> wrote:

> LGTM + 1 suggestion
>
>
> http://codereview.appspot.com/**6201083/diff/2001/src/gpu/gl/**
>
GrGLShaderBuilder.cpp<http://codereview.appspot.com/6201083/diff/2001/src/gpu/gl/GrGLShaderBuilder.cpp>
> File src/gpu/gl/GrGLShaderBuilder.**cpp (right):
>
> http://codereview.appspot.com/**6201083/diff/2001/src/gpu/gl/**
>
GrGLShaderBuilder.cpp#**newcode23<http://codereview.appspot.com/6201083/diff/2001/src/gpu/gl/GrGLShaderBuilder.cpp#newcode23>
> src/gpu/gl/GrGLShaderBuilder.**cpp:23: const int
> GrGLShaderBuilder::fCoordDims = 2;
> Could we move this into the header?
>
>
http://codereview.appspot.com/**6201083/<http://codereview.appspot.com/6201083/>
>

[TomH, 2012-05-14 19:39:03]

On 2012/05/14 19:13:41, bsalomon wrote:
> Could the incoming coords be a grglshadervar? (Maybe a dumb q, writing from
> my phone while eating lunch)

I don't understand the question.

This is a straightforward port across of what's in GrGLProgram now.

[bsalomon, 2012-05-14 19:50:57]

On 2012/05/14 19:39:03, TomH wrote:
> On 2012/05/14 19:13:41, bsalomon wrote:
> > Could the incoming coords be a grglshadervar? (Maybe a dumb q, writing from
> > my phone while eating lunch)
> 
> I don't understand the question.
> 
> This is a straightforward port across of what's in GrGLProgram now.

Right, I get that (LGTM and all that) but I'm wondering whether we should should
pass down a GrGLShaderVar down to the custom program stage rather than a coord
name string ptr and a type set on the shader builder. That is, we start making
GrGLShaderVar the dowels in our tinker toy set.

[TomH, 2012-05-14 19:59:03]

Closed with r3928.