Issue 6201079: Adds Flag to Fingering side support list

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6201079: Adds Flag to Fingering side support list (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by MikeSol

Modified:
11 years, 10 months ago

Reviewers:
Keith, Graham Percival

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Adds Flag to Fingering side support list

Patch Set 2 : Removes add-stem-support from fingering while keeping flag in stem support #

Patch Set 3 : Removes add-stem-support from fingering while keeping flag in stem support #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	A	input/regression/fingering-flag.ly	View		1 chunk	+11 lines, -0 lines	2 comments	Download
	M	lily/new-fingering-engraver.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Keith

http://codereview.appspot.com/6201079/diff/1/input/regression/fingering-flag.ly File input/regression/fingering-flag.ly (right): http://codereview.appspot.com/6201079/diff/1/input/regression/fingering-flag.ly#newcode4 input/regression/fingering-flag.ly:4: texidoc = "Horizontal fingerings avoid flags. add to 'finger-chords.ly' ...

11 years, 11 months ago (2012-05-13 17:39:11 UTC) #1

Keith

http://codereview.appspot.com/6201079/diff/3002/input/regression/fingering-flag.ly File input/regression/fingering-flag.ly (right): http://codereview.appspot.com/6201079/diff/3002/input/regression/fingering-flag.ly#newcode9 input/regression/fingering-flag.ly:9: \set fingeringOrientations = #'(right) \override Fingering #'add-stem-support = ##t

11 years, 11 months ago (2012-05-13 22:32:38 UTC) #2

Keith

11 years, 11 months ago (2012-05-17 07:22:46 UTC) #4

http://codereview.appspot.com/6201079/diff/3002/input/regression/fingering-fl...
File input/regression/fingering-flag.ly (right):

http://codereview.appspot.com/6201079/diff/3002/input/regression/fingering-fl...
input/regression/fingering-flag.ly:9: \set fingeringOrientations = #'(right)
On 2012/05/13 22:32:38, Keith wrote:
> \override Fingering #'add-stem-support = ##t

I don't think your regtest will do what it claims without this.

Expand All Messages | Collapse All Messages