Issue 6201064: trans-mem: make sure clones for functions referenced indirectly are marked as needed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6201064: trans-mem: make sure clones for functions referenced indirectly are marked as needed

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by daveb

Modified:
10 months, 3 weeks ago

Reviewers:
patrick.marlier, aldyh

CC:
gcc-patches_gcc.gnu.org

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	gcc/trans-mem.c	View		3 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

aldyh_redhat.com

12 years, 4 months ago (2012-05-22 17:13:17 UTC) #1

Hi Dave.

> Without this patch we generate calls to TM_GETTMCLONE for functions
> called indirectly, but we don't actually store the clone mapping in
> the clone table because we think the functions are not "needed".
> Compiles fine, dies at runtime.  See GCC Bugzilla – Bug 53008

Have you taken a look at?:
http://gcc.gnu.org/contribute.html

In particular, you should include a testcase, and have tested your patch
as suggested in the above link.

Also, it is customary to include the bugzilla number in the subject as
so:

        Subject: [PR middle-end/53008] trans-mem: make sure clones....

Similarly, the ChangeLog entry should reference "PR middle-end/53008".
This makes the final commit to be referenced automagically from the PR
itself.

All this makes it easier to review your patch.

Thanks.
Aldy

Expand All Messages | Collapse All Messages