Issue 6200064: code review 6200064: runtime: refactor helpgc functionality in preparation f...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6200064: code review 6200064: runtime: refactor helpgc functionality in preparation f... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by dvyukov

Modified:
14 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: refactor helpgc functionality in preparation for parallel GC Parallel GC needs to know in advance how many helper threads will be there. Hopefully it's the last patch before I can tackle parallel sweep phase. The benchmarks are unaffected.

Patch Set 1 #

Patch Set 2 : diff -r 345cbca96c55 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 345cbca96c55 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 95d6aec944d4 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -50 lines)			Patch
M	src/pkg/runtime/malloc.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/mgc0.c	View	1	7 chunks	+14 lines, -21 lines	0 comments	Download
M	src/pkg/runtime/mprof.goc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	2 chunks	+40 lines, -25 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2012-05-11 09:26:27 UTC) #1

dvyukov

14 years ago (2012-05-15 15:11:10 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d7aa3195a018 ***

runtime: refactor helpgc functionality in preparation for parallel GC
Parallel GC needs to know in advance how many helper threads will be there.
Hopefully it's the last patch before I can tackle parallel sweep phase.
The benchmarks are unaffected.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6200064

Expand All Messages | Collapse All Messages