What future errors are we preventing? I supported this warning in a few places where ...
12 years, 7 months ago
(2012-05-10 12:03:51 UTC)
#2
What future errors are we preventing? I supported this warning in a few places
where we were leaving a parameter in an uninitialized state (e.g.
SkMatrix::invert), as the function's result indicated that the method had
failed. Does that situation arise here?
I made the error of using MakeEmpty where I should've used setEmpty. This error did ...
12 years, 7 months ago
(2012-05-10 12:18:05 UTC)
#3
I made the error of using MakeEmpty where I should've used setEmpty. This error
did leave the object I was invoking it on in an unexpected state (albeit in a
different manner than in the SkMatrix::invert case). It seems like there should
be no circumstances in which you should be calling the Make* methods w/o using
their return value.
Issue 6200060: Warn if return values from SkRect's Make* methods are ignored
(Closed)
Created 12 years, 7 months ago by robertphillips
Modified 12 years, 7 months ago
Reviewers: bsalomon, reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0