Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1009)

Issue 6200060: Warn if return values from SkRect's Make* methods are ignored (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by robertphillips
Modified:
12 years, 6 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Warn if return value from SkRect's Make* methods is ignored

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M include/core/SkRect.h View 4 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 4
robertphillips
This adds no new warnings on Windows but could prevent future errors
12 years, 6 months ago (2012-05-09 21:54:53 UTC) #1
reed1
What future errors are we preventing? I supported this warning in a few places where ...
12 years, 6 months ago (2012-05-10 12:03:51 UTC) #2
robertphillips
I made the error of using MakeEmpty where I should've used setEmpty. This error did ...
12 years, 6 months ago (2012-05-10 12:18:05 UTC) #3
robertphillips
12 years, 6 months ago (2012-05-10 14:51:20 UTC) #4
Received verbal LGTM from Mike

committed as r3894.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b