Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2214)

Issue 6199063: Fix for Android ClipCache unit test crash (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
Reviewers:
bsalomon, DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The surface cause of the crash was my failure to check the pointer returned from createUncachedTexture. The deeper cause of the crash was that the nexus s doesn't seem to support any single channel texture formats.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M tests/ClipCacheTest.cpp View 1 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6
robertphillips
12 years, 4 months ago (2012-05-10 19:42:21 UTC) #1
DerekS
Brian may want to look at this as he knows more about this code than ...
12 years, 4 months ago (2012-05-10 19:50:53 UTC) #2
bsalomon
http://codereview.appspot.com/6199063/diff/1/tests/ClipCacheTest.cpp File tests/ClipCacheTest.cpp (right): http://codereview.appspot.com/6199063/diff/1/tests/ClipCacheTest.cpp#newcode25 tests/ClipCacheTest.cpp:25: desc.fConfig = kRGBA_8888_UPM_GrPixelConfig; Was UPM chosen for any particular ...
12 years, 4 months ago (2012-05-10 19:55:16 UTC) #3
robertphillips
http://codereview.appspot.com/6199063/diff/1/tests/ClipCacheTest.cpp File tests/ClipCacheTest.cpp (right): http://codereview.appspot.com/6199063/diff/1/tests/ClipCacheTest.cpp#newcode25 tests/ClipCacheTest.cpp:25: desc.fConfig = kRGBA_8888_UPM_GrPixelConfig; On 2012/05/10 19:55:16, bsalomon wrote: > ...
12 years, 4 months ago (2012-05-10 20:36:16 UTC) #4
bsalomon
On 2012/05/10 20:36:16, robertphillips wrote: > http://codereview.appspot.com/6199063/diff/1/tests/ClipCacheTest.cpp > File tests/ClipCacheTest.cpp (right): > > http://codereview.appspot.com/6199063/diff/1/tests/ClipCacheTest.cpp#newcode25 > ...
12 years, 4 months ago (2012-05-10 21:01:23 UTC) #5
robertphillips
12 years, 4 months ago (2012-05-10 21:27:09 UTC) #6
committed as r3902
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b