Split createAlphaClipMask in two to allow reuse with SW-only path

The existing gpu clip mask creation path and the nascent SW-only clip mask creation path share the same setup (bounds determination, cache check, texture acquisition).

[bsalomon, 2012-05-11 14:45:21]

Overall lgtm, some minor nits.

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:86: if (createMaskInSW()) {
I hate to bring this up this late but our style guide suggests calling naming
file_local_functions_like_this() so that they don't look like members missing a
this->. We aren't terribly consistent about this, though.

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:478: getAccum(gpu, bounds, maskStorage);
this->

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:491: if (clipMaskPreamble(gpu, clipIn, result,
resultBounds, &accum)) {
this->

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:786: if (clipMaskPreamble(gpu, clipIn, result,
resultBounds, &accum)) {
this->

[reed1, 2012-05-11 15:10:51]

if we're more consistent with calling local methods this->way(), we can possible
relax the naming rule for static_local_functions.

[reed1, 2012-05-11 15:11:07]

if we're more consistent with calling local methods this->way(), we can possibly
 relax the naming rule for static_local_functions.

[robertphillips, 2012-05-11 15:21:11]

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:86: if (createMaskInSW()) {
On 2012/05/11 14:45:21, bsalomon wrote:
> I hate to bring this up this late but our style guide suggests calling naming
> file_local_functions_like_this() so that they don't look like members missing
a
> this->. We aren't terribly consistent about this, though.

Done.

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:478: getAccum(gpu, bounds, maskStorage);
On 2012/05/11 14:45:21, bsalomon wrote:
> this->

Done.

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:491: if (clipMaskPreamble(gpu, clipIn, result,
resultBounds, &accum)) {
On 2012/05/11 14:45:21, bsalomon wrote:
> this->

Done.

http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:786: if (clipMaskPreamble(gpu, clipIn, result,
resultBounds, &accum)) {
On 2012/05/11 14:45:21, bsalomon wrote:
> this->

Done.

[bsalomon, 2012-05-11 15:26:33]

On 2012/05/11 15:21:11, robertphillips wrote:
> http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp
> File src/gpu/GrClipMaskManager.cpp (right):
> 
>
http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
> src/gpu/GrClipMaskManager.cpp:86: if (createMaskInSW()) {
> On 2012/05/11 14:45:21, bsalomon wrote:
> > I hate to bring this up this late but our style guide suggests calling
naming
> > file_local_functions_like_this() so that they don't look like members
missing
> a
> > this->. We aren't terribly consistent about this, though.
> 
> Done.
> 
>
http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
> src/gpu/GrClipMaskManager.cpp:478: getAccum(gpu, bounds, maskStorage);
> On 2012/05/11 14:45:21, bsalomon wrote:
> > this->
> 
> Done.
> 
>
http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
> src/gpu/GrClipMaskManager.cpp:491: if (clipMaskPreamble(gpu, clipIn, result,
> resultBounds, &accum)) {
> On 2012/05/11 14:45:21, bsalomon wrote:
> > this->
> 
> Done.
> 
>
http://codereview.appspot.com/6198065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
> src/gpu/GrClipMaskManager.cpp:786: if (clipMaskPreamble(gpu, clipIn, result,
> resultBounds, &accum)) {
> On 2012/05/11 14:45:21, bsalomon wrote:
> > this->
> 
> Done.

LGTM

[robertphillips, 2012-05-11 15:33:13]

committed as r3910