Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(985)

Issue 6198048: Make GrGLDefines.h be a private header (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by bsalomon
Modified:
12 years, 7 months ago
Reviewers:
robertphilips, robertphillips, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -699 lines) Patch
M gyp/gpu.gyp View 2 chunks +1 line, -1 line 0 comments Download
M include/gpu/gl/GrGLConfig.h View 1 chunk +0 lines, -1 line 0 comments Download
D include/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -697 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/debug/GrBufferObj.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/debug/GrShaderObj.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
bsalomon
There's no reason for clients to be using our copy of GL macros. We add ...
12 years, 7 months ago (2012-05-07 17:22:32 UTC) #1
bsalomon
On 2012/05/07 17:22:32, bsalomon wrote: > There's no reason for clients to be using our ...
12 years, 7 months ago (2012-05-07 17:23:23 UTC) #2
TomH
LGTM. Very.
12 years, 7 months ago (2012-05-07 17:23:40 UTC) #3
robertphillips
LGTM
12 years, 7 months ago (2012-05-07 17:26:57 UTC) #4
bsalomon
12 years, 7 months ago (2012-05-07 18:15:47 UTC) #5
Closed with r3851,2.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b