Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 6197076: Create GrGLShaderBuilder class (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by TomH
Modified:
12 years, 4 months ago
Reviewers:
bsalomon
CC:
senorblanco, twiz1, robertphillips
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

We need to have access to most of the ShaderCodeSegments structure to add varying variables to shaders without breaking geometry-shaders. Brian's argued for merging the various emit*() and setup*() functions on GrGLProgramStage; I'd rather keep them distinct; either way, we're going to need to pass that struct to them. This CL extracts it from inside GrGLProgram.cpp and starts populating its interface.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -135 lines) Patch
M gyp/gpu.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 19 chunks +28 lines, -129 lines 0 comments Download
A src/gpu/gl/GrGLShaderBuilder.h View 1 chunk +58 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLShaderBuilder.cpp View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 3
TomH
12 years, 4 months ago (2012-05-11 20:35:02 UTC) #1
bsalomon
On 2012/05/11 20:35:02, TomH wrote: LGTM
12 years, 4 months ago (2012-05-11 20:37:34 UTC) #2
TomH
12 years, 4 months ago (2012-05-11 20:42:27 UTC) #3
Closed with r3916.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b