Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1204)

Issue 6195051: First pass at accelerating gpu-based AA clipping (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by robertphillips
Modified:
12 years, 3 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This delivery adds two small enhancements to accelerate gpu AA clipping. The ClipMaskManager now attempts to reuse the cached texture and delays creation of the temp texture until it is needed. These two changes make the AA path go from 66-400x slower (than the stencil buffer path) to being 3-17x slower. This delivery also adds a new bench test case for profiling.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -15 lines) Patch
M bench/AAClipBench.cpp View 4 chunks +90 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.h View 4 chunks +47 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 9 chunks +47 lines, -10 lines 2 comments Download

Messages

Total messages: 6
robertphillips
12 years, 3 months ago (2012-05-07 12:09:00 UTC) #1
bsalomon
http://codereview.appspot.com/6195051/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): http://codereview.appspot.com/6195051/diff/1/src/gpu/GrClipMaskManager.cpp#newcode372 src/gpu/GrClipMaskManager.cpp:372: if (fAACache.getLastMaskWidth() >= desc.fWidth && Do we want to ...
12 years, 3 months ago (2012-05-07 13:52:44 UTC) #2
robertphillips
http://codereview.appspot.com/6195051/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): http://codereview.appspot.com/6195051/diff/1/src/gpu/GrClipMaskManager.cpp#newcode372 src/gpu/GrClipMaskManager.cpp:372: if (fAACache.getLastMaskWidth() >= desc.fWidth && Given the current usage ...
12 years, 3 months ago (2012-05-07 17:29:20 UTC) #3
robertphillips
One other item to consider is that Mike brought up the possibility of pushing Skia's ...
12 years, 3 months ago (2012-05-07 17:31:47 UTC) #4
bsalomon
On 2012/05/07 17:31:47, robertphillips wrote: > One other item to consider is that Mike brought ...
12 years, 3 months ago (2012-05-07 18:02:47 UTC) #5
robertphillips
12 years, 3 months ago (2012-05-07 18:08:01 UTC) #6
committed as r3853
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b