Issue 6189054: Move GL function prototype typdefs to a separate header

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6189054: Move GL function prototype typdefs to a separate header (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by bsalomon

Modified:
12 years, 7 months ago

Reviewers:
robertphillips, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -148 lines)			Patch
M	gyp/gpu.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	include/gpu/gl/GrGLFunctions.h	View	1 chunk	+160 lines, -0 lines	0 comments	Download
M	include/gpu/gl/GrGLInterface.h	View	2 chunks	+1 line, -148 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

I find this makes GrGLInterface.h easier to read. http://codereview.appspot.com/6189054/diff/1/include/gpu/gl/GrGLInterface.h File include/gpu/gl/GrGLInterface.h (left): http://codereview.appspot.com/6189054/diff/1/include/gpu/gl/GrGLInterface.h#oldcode243 include/gpu/gl/GrGLInterface.h:243: kProbe_GrGLCapability ...

12 years, 7 months ago (2012-05-07 19:42:36 UTC) #1

TomH

LGTM, although I might like to see a comment in GrGLFunctions.h about why that file ...

12 years, 7 months ago (2012-05-07 19:43:55 UTC) #2

Closed with r3864

Expand All Messages | Collapse All Messages