Improved DDS Texture Support

Allows DDS textures to remain compressed on the video card.

[ideasman42, 2012-06-28 09:52:25]

https://codereview.appspot.com/6188090/diff/1/source/blender/gpu/intern/gpu_d...
File source/blender/gpu/intern/gpu_draw.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/gpu/intern/gpu_d...
source/blender/gpu/intern/gpu_draw.c:630: int oldh= recth;
these arn't used

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/all...
File source/blender/imbuf/intern/allocimbuf.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/all...
source/blender/imbuf/intern/allocimbuf.c:166: free(ibuf->dds_data.data);
shouldn't this use MEM_freeN() ? *(allocations too...)

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/dds...
File source/blender/imbuf/intern/dds/DirectDrawSurface.cpp (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/dds...
source/blender/imbuf/intern/dds/DirectDrawSurface.cpp:1138: // It was easier to
copy this function from upstream than to resync.
picky - prefer C comments for descriptive text in C files.

https://codereview.appspot.com/6188090/diff/1/source/gameengine/Ketsji/BL_Tex...
File source/gameengine/Ketsji/BL_Texture.cpp (right):

https://codereview.appspot.com/6188090/diff/1/source/gameengine/Ketsji/BL_Tex...
source/gameengine/Ketsji/BL_Texture.cpp:194: void
BL_Texture::InitGLCompressedTex(ImBuf* ibuf, bool mipmap)
should cross reference - GPU_create_gl_tex_compressed(), if copied code cant be
shared

[Moguri, 2012-06-28 20:27:48]

https://codereview.appspot.com/6188090/diff/1/source/blender/gpu/intern/gpu_d...
File source/blender/gpu/intern/gpu_draw.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/gpu/intern/gpu_d...
source/blender/gpu/intern/gpu_draw.c:630: int oldh= recth;
On 2012/06/28 09:52:25, ideasman42 wrote:
> these arn't used

Removed these.

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/all...
File source/blender/imbuf/intern/allocimbuf.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/all...
source/blender/imbuf/intern/allocimbuf.c:166: free(ibuf->dds_data.data);
On 2012/06/28 09:52:25, ideasman42 wrote:
> shouldn't this use MEM_freeN() ? *(allocations too...)

dds_data.data is allocated by the DDS library that we're using (part of Nvidia
Texture Tools). Since NTT doesn't use MEM_mallocN() should we still use
MEM_freeN()?

https://codereview.appspot.com/6188090/diff/1/source/gameengine/Ketsji/BL_Tex...
File source/gameengine/Ketsji/BL_Texture.cpp (right):

https://codereview.appspot.com/6188090/diff/1/source/gameengine/Ketsji/BL_Tex...
source/gameengine/Ketsji/BL_Texture.cpp:194: void
BL_Texture::InitGLCompressedTex(ImBuf* ibuf, bool mipmap)
On 2012/06/28 09:52:25, ideasman42 wrote:
> should cross reference - GPU_create_gl_tex_compressed(), if copied code cant
be
> shared

I've put as much shared code as I can into a bf_gpu function that both now call.

[ideasman42, 2012-06-29 19:49:25]

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/all...
File source/blender/imbuf/intern/allocimbuf.c (right):

https://codereview.appspot.com/6188090/diff/1/source/blender/imbuf/intern/all...
source/blender/imbuf/intern/allocimbuf.c:166: free(ibuf->dds_data.data);
no, in that case simple /* alloc is done by ____ */ comment is fine.