Adding a credentials_from_code and credentials_from_clientsecrets_and_code function

Adding a credentials_from_code and credentials_from_clientsecrets_and_code function, based on suggestions from Joe. Both functions create a OAuth2WebServerFlow object, and then perform just the steps necessary to exchange an authorization_code for an access token, which gets wrapped up in a OAuth2Credentials object.

These are primarily used for the "Get an authorization code from the client Javascript library, then pass that down to the server to exchange for an access_token" approach.

[jcgregorio_google, 2012-05-14 21:16:13]

Also, each new function needs at least one unit test.

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py#newcode887
oauth2client/client.py:887:
token_uri='https://accounts.google.com/o/oauth2/token'):
80 chars

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py#newcode918
oauth2client/client.py:918: http=None, user_agent=None):
user_agent is unused.

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py#newcode919
oauth2client/client.py:919: """Returns a set of OAuth2Credentials from a
clientsecrets file and an
Keep to one line, also make a sentence by ending with a '.'.

[kerp, 2012-05-15 21:44:42]

> Also, each new function needs at least one unit test.

Done! Whew. That took longer than expected. :)

[kerp, 2012-05-15 21:45:00]

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py#newcode887
oauth2client/client.py:887:
token_uri='https://accounts.google.com/o/oauth2/token'):
On 2012/05/14 21:16:13, jcgregorio_google wrote:
> 80 chars

Done.

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py#newcode918
oauth2client/client.py:918: http=None, user_agent=None):
On 2012/05/14 21:16:13, jcgregorio_google wrote:
> user_agent is unused.

Done.

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py#newcode919
oauth2client/client.py:919: """Returns a set of OAuth2Credentials from a
clientsecrets file and an
On 2012/05/14 21:16:13, jcgregorio_google wrote:
> Keep to one line, also make a sentence by ending with a '.'.

Done.

http://codereview.appspot.com/6188069/diff/1/oauth2client/client.py#newcode919
oauth2client/client.py:919: """Returns a set of OAuth2Credentials from a
clientsecrets file and an
On 2012/05/14 21:16:13, jcgregorio_google wrote:
> Keep to one line, also make a sentence by ending with a '.'.

Done.

[jcgregorio_google, 2012-05-21 12:58:51]

http://codereview.appspot.com/6188069/diff/4001/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6188069/diff/4001/oauth2client/client.py#newcod...
oauth2client/client.py:899: user_agent string, optional HTTP User-Agent to
provide for this application.
user_agent: string,

Both here and below.

http://codereview.appspot.com/6188069/diff/4001/oauth2client/client.py#newcod...
oauth2client/client.py:902: Returns:
Also add a Raises: section since this could raise a
clientsecrets.InvalidClientSecretsError or an UnknownClientSecretsFlowError, or
a FlowExchangeError.

http://codereview.appspot.com/6188069/diff/4001/oauth2client/client.py#newcod...
oauth2client/client.py:903: A OAuth2Credentials object.
An

[kerp, 2012-05-21 19:57:08]

Done. PTAL

http://codereview.appspot.com/6188069/diff/4001/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6188069/diff/4001/oauth2client/client.py#newcod...
oauth2client/client.py:899: user_agent string, optional HTTP User-Agent to
provide for this application.
On 2012/05/21 12:58:51, jcgregorio_google wrote:
> user_agent: string,
> 
> Both here and below.

Done.

http://codereview.appspot.com/6188069/diff/4001/oauth2client/client.py#newcod...
oauth2client/client.py:902: Returns:
On 2012/05/21 12:58:51, jcgregorio_google wrote:
> Also add a Raises: section since this could raise a
> clientsecrets.InvalidClientSecretsError or an UnknownClientSecretsFlowError,
or
> a FlowExchangeError.

Done. Added all three to the function below, and the FlowExchangeError to this
call.

http://codereview.appspot.com/6188069/diff/4001/oauth2client/client.py#newcod...
oauth2client/client.py:903: A OAuth2Credentials object.
On 2012/05/21 12:58:51, jcgregorio_google wrote:
> An 

Done.

[jcgregorio_google, 2012-06-05 20:43:35]

http://codereview.appspot.com/6188069/diff/10001/tests/test_oauth2client.py
File tests/test_oauth2client.py (right):

http://codereview.appspot.com/6188069/diff/10001/tests/test_oauth2client.py#n...
tests/test_oauth2client.py:30: import os
alphabetical order for imports

[kerp, 2012-06-12 21:44:26]

http://codereview.appspot.com/6188069/diff/10001/tests/test_oauth2client.py
File tests/test_oauth2client.py (right):

http://codereview.appspot.com/6188069/diff/10001/tests/test_oauth2client.py#n...
tests/test_oauth2client.py:30: import os
On 2012/06/05 20:43:35, jcgregorio_google wrote:
> alphabetical order for imports

Done. I'm assuming we prefer case-sensitive sorting here? (i.e. ABCabc, not
AaBbCc) because that will affect the credentials_from_code lines below
otherwise.

[mimming, 2012-06-13 17:35:03]

LGTM

[jcgregorio_google, 2012-06-14 13:09:26]

On 2012/06/13 17:35:03, mimming wrote:
> LGTM

lgtm

[jcgregorio_google, 2012-06-14 13:09:49]

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=3ebaf448901...

  Thanks!

On 2012/06/14 13:09:26, jcgregorio_google wrote:
> On 2012/06/13 17:35:03, mimming wrote:
> > LGTM
> 
> lgtm