Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2219)

Issue 6188045: Fix for performance regression due to r3832 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by robertphillips
Modified:
12 years, 6 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

r3832 caused the GrInOrderDrawBuffer to push state too often. This patch moves the new behavior modifying flag to its own field so it won't "change" the draw state.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
src/gpu/GrDrawState.h View 7 chunks +34 lines, -5 lines 0 comments Download
src/gpu/GrInOrderDrawBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
src/gpu/gl/GrGpuGL.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
robertphillips
This patch reduces picture_playback* from ~998 msecs to ~738 msecs.
12 years, 6 months ago (2012-05-04 16:26:27 UTC) #1
TomH
LGTM. (Although those performance numbers are both worse than what I was seeing; the magnitude ...
12 years, 6 months ago (2012-05-04 16:29:23 UTC) #2
robertphillips
committed as r3840
12 years, 6 months ago (2012-05-04 16:35:29 UTC) #3
robertphillips
12 years, 6 months ago (2012-05-04 16:39:18 UTC) #4
I suspect you were running NULLGPU for which I get:
   old: ~697 new: ~527
The numbers I reported earlier were for GPU.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b