Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3774)

Issue 6183044: Fix to prevent infinite recursion during AA clip generation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When path rendering is deferred, the GrInOrderDrawBuffer collects the paths and replays them. During path replaying an AA clip mask may need to be generated. If the AA clip mask generation code encounters a path that cannot be rendered on the gpu it uses the SW path rendering code. The SW path rendering code can then recursively kick off replaying of the stored paths - leading to an infinite loop. This patch short circuits potential loops by hiding the GrInOrderDrawBuffer while it is being replayed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/gpu/GrContext.cpp View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 3
TomH
LGTM. Feels like we might be missing an opportunity to cache the recursive mumblefrotz, but ...
12 years, 4 months ago (2012-05-03 16:26:47 UTC) #1
robertphillips
12 years, 4 months ago (2012-05-03 16:27:10 UTC) #2
robertphillips
12 years, 4 months ago (2012-05-03 16:30:07 UTC) #3
committed as r3831
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b