Issue 6174046: code review 6174046: go.crypto/ssh: struct renaming

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6174046: code review 6174046: go.crypto/ssh: struct renaming (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by dfc

Modified:
11 years, 11 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

go.crypto/ssh: struct renaming This CL is in preparation for 6128059. * rename channel -> serverChan * rename chanlist -> chanList * normalise theirId/MyId/id/peersId -> localId/remoteId

Patch Set 1 #

Patch Set 2 : diff -r f7dd94cf509c https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r f7dd94cf509c https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r f7dd94cf509c https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r f7dd94cf509c https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r f7dd94cf509c https://code.google.com/p/go.crypto #

Patch Set 7 : diff -r f7dd94cf509c https://code.google.com/p/go.crypto #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -95 lines)			Patch
M	ssh/channel.go	View	1	18 chunks	+25 lines, -25 lines	0 comments	Download
M	ssh/client.go	View	1 2	13 chunks	+36 lines, -36 lines	0 comments	Download
M	ssh/server.go	View	1	5 chunks	+8 lines, -8 lines	0 comments	Download
M	ssh/session.go	View	1 2	6 chunks	+8 lines, -8 lines	0 comments	Download
M	ssh/session_test.go	View	1	9 chunks	+15 lines, -15 lines	0 comments	Download
M	ssh/tcpip.go	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dfc

Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

11 years, 11 months ago (2012-05-04 01:11:52 UTC) #1

dfc

Hello agl@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 11 months ago (2012-05-04 11:54:58 UTC) #2

dfc

11 years, 11 months ago (2012-05-04 21:59:54 UTC) #4

*** Submitted as
http://code.google.com/p/go/source/detail?r=249fab80a9e4&repo=crypto ***

go.crypto/ssh: struct renaming

This CL is in preparation for 6128059.

* rename channel -> serverChan
* rename chanlist -> chanList
* normalise theirId/MyId/id/peersId -> localId/remoteId

R=agl
CC=golang-dev
http://codereview.appspot.com/6174046

Expand All Messages | Collapse All Messages