Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(871)

Issue 6161043: use fuzzy name comparision (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by guanqun
Modified:
12 years, 2 months ago
Reviewers:
robertphillips, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

use fuzzy name comparision Sometimes, it's hard to type the correct name, (e.g. missing an "s" or forgetting the prefix "GM:"), so I think this change would help developers a little bit. :) BUG= TEST=

Patch Set 1 #

Patch Set 2 : list all slides' names #

Patch Set 3 : show all slides when --slide doesn't find one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M samplecode/SampleApp.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5
guanqun
Please review, if it's OK, please help land this CL.
12 years, 2 months ago (2012-05-02 05:41:50 UTC) #1
TomH
Agreed that this is a pain point. Personally, I'd rather have SampleApp exit early on ...
12 years, 2 months ago (2012-05-02 17:44:16 UTC) #2
guanqun
On 2012/05/02 17:44:16, TomH wrote: > Agreed that this is a pain point. > > ...
12 years, 2 months ago (2012-05-03 01:07:20 UTC) #3
TomH
LGTM
12 years, 2 months ago (2012-05-03 15:41:44 UTC) #4
robertphillips
12 years, 2 months ago (2012-05-03 18:23:11 UTC) #5
LGTM

committed as r3835
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b