Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1259)

Issue 61510043: Add documentation for dodecaphonic-no-repeat

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by uliska
Modified:
10 years, 2 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add documentation for dodecaphonic-no-repeat Add dodecaphonic-no-repeat accidentalStyle This adds an accidental style that works like the dodecaphonic style except that it does _not_ print an accidental if the note is in the same voice immediately preceded with a note of the same pitch. The contribution is by David Nalesnik.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reword documentation according to suggestions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M Documentation/notation/pitches.itely View 1 1 chunk +58 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4
uliska
This is an addition that David Nalesnik provided upon my request. I consider this a ...
10 years, 2 months ago (2014-02-10 12:44:28 UTC) #1
pkx166h
Thanks Urs. Some minor points. https://codereview.appspot.com/61510043/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/61510043/diff/1/Documentation/notation/pitches.itely#newcode2453 Documentation/notation/pitches.itely:2453: This rule reflects a ...
10 years, 2 months ago (2014-02-10 12:50:27 UTC) #2
uliska
Reword documentation according to suggestions.
10 years, 2 months ago (2014-02-10 13:17:56 UTC) #3
uliska
10 years, 2 months ago (2014-02-10 13:18:22 UTC) #4
On 2014/02/10 12:50:27, J_lowe wrote:
> Thanks Urs.
> 
> Some minor points.
> 
>
https://codereview.appspot.com/61510043/diff/1/Documentation/notation/pitches...
> File Documentation/notation/pitches.itely (right):
> 
>
https://codereview.appspot.com/61510043/diff/1/Documentation/notation/pitches...
> Documentation/notation/pitches.itely:2453: This rule reflects a practice used
by
> numerous contemporary
> This rule...
> 
> Above we have used the term 'style' as opposed to rule I think. I have no
> preference, but make sure we are consistent in this section, that's all.

I see your point, but actually each accidental style's description starts with
"This rule".
I think this refers to the defined rule that is responsible for creating the
display style.

So I wouldn't change this.

> 
> ...reflects a practice used by numerous contemporary...
> 
> irrelevant (interesting but just 'fluff'), perhaps just remove the first
> sentence entirely and start the next sentence (NB the '--' you use is never
> repeated after the digression in the sentence, so it makes the 'While..' if
the
> sentence look strange. So just start the sentence with 'Like the dodecaphonic
> accidental...' and be done.

Done
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b