Added AA clipping to old shader path

This CL makes use of the new shader stage to add gpu soft-clipping to the old shader path.

[TomH, 2012-05-01 15:59:40]

LGTM after nits / minor changes.

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:36: static const int maskStage =
GrPaint::kTotalStages+1;
OK, I just refused to review the commit that would change this (?) - but after
digging into this enough to almost-kinda-understand it, perhaps I'll go back and
sign off there. Is it time that we recorded more on the wiki about how Ganesh
works?

(After talking to people at game companies, I suspect the problem with the old
shader generator may be that we didn't have a well-defined model, not that our
approach was wrong.)

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:509: *resultBounds = bounds;
Were we not using these before? Or were they getting into the GPU draw state by
some implicit side-effect?

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrDrawState.h
File src/gpu/GrDrawState.h (right):

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrDrawState.h#newcode334
src/gpu/GrDrawState.h:334: * Sets the matrix applied to vertex positions.
+1

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrDrawTarget.h#newcode213
src/gpu/GrDrawTarget.h:213: // vertex layout is a
StagePosAsTexCoordVertexLayoutBit flag
Please:
1. Switch to doxygen-style comment.
2. Assert that flag is StagePosAsTexCoordVertexLayoutBit.

[robertphillips, 2012-05-01 17:16:39]

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:36: static const int maskStage =
GrPaint::kTotalStages+1;
The other change is actually to make the SW path use the same TU (#3) as the gpu
AA clip path (this code) instead of using the glyph's texture unit (#2).

We definitely need better documentation of Ganesh!

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrClipMaskManager.cpp#ne...
src/gpu/GrClipMaskManager.cpp:509: *resultBounds = bounds;
Before this delivery I was only generating the mask but never using it. To
actually use it I needed the generation method to actually return its result.

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

http://codereview.appspot.com/6139065/diff/1/src/gpu/GrDrawTarget.h#newcode213
src/gpu/GrDrawTarget.h:213: // vertex layout is a
StagePosAsTexCoordVertexLayoutBit flag
On 2012/05/01 15:59:40, TomH wrote:
> Please:
> 1. Switch to doxygen-style comment.
> 2. Assert that flag is StagePosAsTexCoordVertexLayoutBit.

Done.

[robertphillips, 2012-05-01 17:23:32]

committed as r3812