Issue 6139043: Some cleanup of GrResource

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6139043: Some cleanup of GrResource (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by bsalomon

Modified:
12 years, 4 months ago

Reviewers:
robertphillips, TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : kjsdf #

Total comments: 4

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -13 lines)			Patch
	M	include/gpu/GrResource.h	View		2 chunks	+9 lines, -13 lines	4 comments	Download
	M	src/gpu/GrResource.cpp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

TomH

LGTM. Could we have a one or two sentence description of the purpose of the ...

12 years, 4 months ago (2012-04-27 17:05:46 UTC) #2

robertphillips

LGTM w/ 1 nit + a question http://codereview.appspot.com/6139043/diff/1003/include/gpu/GrResource.h File include/gpu/GrResource.h (right): http://codereview.appspot.com/6139043/diff/1003/include/gpu/GrResource.h#newcode74 include/gpu/GrResource.h:74: GrGpu* fGpu; ...

12 years, 4 months ago (2012-04-27 17:12:57 UTC) #3

bsalomon

http://codereview.appspot.com/6139043/diff/1003/include/gpu/GrResource.h File include/gpu/GrResource.h (right): http://codereview.appspot.com/6139043/diff/1003/include/gpu/GrResource.h#newcode74 include/gpu/GrResource.h:74: GrGpu* fGpu; // not reffed. The GrGpu can be ...

12 years, 4 months ago (2012-04-27 17:26:27 UTC) #4

bsalomon

12 years, 4 months ago (2012-04-27 17:26:49 UTC) #5

Closed with r3782 (with comment added by Tom's request).

Expand All Messages | Collapse All Messages