Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(987)

Issue 6138057: Moved SW path rendering to new texture unit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
Reviewers:
bsalomon, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This change simply makes the SW path rendering code path share the same sampler as the gpu-based AA clip path rendering. This frees up the old sampler exclusively for glyph rendering. The SW path and the gpu-based AA clip path will not conflict since, when the gpu AA clip path uses the SW path the SW path must complete before the gpu path can render. Similarly, when the SW path is invoked and the gpu path is used to generate the clip mask, the gpu path must complete before the SW path can render.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
robertphillips
12 years, 4 months ago (2012-05-01 14:56:23 UTC) #1
TomH
I don't understand this part of the code well enough to sign off on it ...
12 years, 4 months ago (2012-05-01 14:58:09 UTC) #2
robertphillips
I have added Brian - it is low enough priority that it can wait a ...
12 years, 4 months ago (2012-05-01 15:00:43 UTC) #3
TomH
On 2012/05/01 15:00:43, robertphillips wrote: > I have added Brian - it is low enough ...
12 years, 4 months ago (2012-05-01 16:11:42 UTC) #4
robertphillips
12 years, 4 months ago (2012-05-01 17:26:13 UTC) #5
committed as r3813
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b