Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1597)

Issue 6138056: Moved SW path renderer from GrContext.cpp to GrSoftwarePathRenderer.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by robertphillips
Modified:
12 years, 6 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Mostly mechanical refactoring to move SW path rendering to new home.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -235 lines) Patch
M src/gpu/GrContext.cpp View 3 chunks +1 line, -230 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 2 chunks +223 lines, -5 lines 6 comments Download

Messages

Total messages: 3
robertphillips
12 years, 6 months ago (2012-05-01 14:08:51 UTC) #1
TomH
LGTM modulo nits. Three cheers for shrinking GrContext. http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.cpp File src/gpu/GrSoftwarePathRenderer.cpp (right): http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.cpp#newcode23 src/gpu/GrSoftwarePathRenderer.cpp:23: // ...
12 years, 6 months ago (2012-05-01 14:18:55 UTC) #2
robertphillips
12 years, 6 months ago (2012-05-01 14:31:43 UTC) #3
committed as r3807

http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.cpp
File src/gpu/GrSoftwarePathRenderer.cpp (right):

http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.c...
src/gpu/GrSoftwarePathRenderer.cpp:23: // TODO: the SW renderer can also handle
non-AA paths
On 2012/05/01 14:18:55, TomH wrote:
> Not clear to me what this TODO means. Could we amplify it a little?

Done.

http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.c...
src/gpu/GrSoftwarePathRenderer.cpp:27: return true;
"filled out" meant filling out the functionality in onDrawPath (i.e., this
refactoring). Basically we didn't want the GrSoftwarePathRenderer to try to do
anything until it actually had its implementation.

http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.c...
src/gpu/GrSoftwarePathRenderer.cpp:202: bool
GrSoftwarePathRenderer::onDrawPath(const SkPath& path,
Yes - the GrPathRenderer base class' drawPath double checks that the draw is
kosher then calls onDrawPath
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b