Issue 6138056: Moved SW path renderer from GrContext.cpp to GrSoftwarePathRenderer.cpp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6138056: Moved SW path renderer from GrContext.cpp to GrSoftwarePathRenderer.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by robertphillips

Modified:
12 years, 4 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Mostly mechanical refactoring to move SW path rendering to new home.

Patch Set 1 #

Total comments: 6

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+224 lines, -235 lines)			Patch
	M	src/gpu/GrContext.cpp	View		3 chunks	+1 line, -230 lines	0 comments	Download
	M	src/gpu/GrSoftwarePathRenderer.cpp	View		2 chunks	+223 lines, -5 lines	6 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM modulo nits. Three cheers for shrinking GrContext. http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.cpp File src/gpu/GrSoftwarePathRenderer.cpp (right): http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.cpp#newcode23 src/gpu/GrSoftwarePathRenderer.cpp:23: // ...

12 years, 4 months ago (2012-05-01 14:18:55 UTC) #2

robertphillips

12 years, 4 months ago (2012-05-01 14:31:43 UTC) #3

committed as r3807

http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.cpp
File src/gpu/GrSoftwarePathRenderer.cpp (right):

http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.c...
src/gpu/GrSoftwarePathRenderer.cpp:23: // TODO: the SW renderer can also handle
non-AA paths
On 2012/05/01 14:18:55, TomH wrote:
> Not clear to me what this TODO means. Could we amplify it a little?

Done.

http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.c...
src/gpu/GrSoftwarePathRenderer.cpp:27: return true;
"filled out" meant filling out the functionality in onDrawPath (i.e., this
refactoring). Basically we didn't want the GrSoftwarePathRenderer to try to do
anything until it actually had its implementation.

http://codereview.appspot.com/6138056/diff/1/src/gpu/GrSoftwarePathRenderer.c...
src/gpu/GrSoftwarePathRenderer.cpp:202: bool
GrSoftwarePathRenderer::onDrawPath(const SkPath& path,
Yes - the GrPathRenderer base class' drawPath double checks that the draw is
kosher then calls onDrawPath

Expand All Messages | Collapse All Messages