Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1602)

Issue 6135046: Bumped num stages to 4 in preparation for AA clipping (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by robertphillips
Modified:
12 years, 7 months ago
Reviewers:
bsalomon, junov1, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Bumped num stages to 4 in preparation for AA clipping

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M src/gpu/GrDrawState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +16 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7
robertphillips
12 years, 7 months ago (2012-04-27 18:38:01 UTC) #1
bsalomon
LGTM, let's keep an eye on bench to see what happens... this affects the length ...
12 years, 7 months ago (2012-04-27 18:54:11 UTC) #2
TomH
Ooh, yeah, that could be bad.
12 years, 7 months ago (2012-04-27 18:57:09 UTC) #3
robertphillips
committed as r3783
12 years, 7 months ago (2012-04-27 19:00:26 UTC) #4
TomH
Just to follow up on the bench question: Mac might have gotten slightly worse, Windows ...
12 years, 7 months ago (2012-04-30 18:09:02 UTC) #5
robertphillips
I was watching these Friday afternoon and came to the same conclusions. On Mon, Apr ...
12 years, 7 months ago (2012-04-30 19:04:44 UTC) #6
junov1
12 years, 7 months ago (2012-04-30 22:46:07 UTC) #7
FYI, that patch just used-up the last available vertex attribute index for
platforms that are limited to 8.

On Mon, Apr 30, 2012 at 3:04 PM, Robert Phillips
<robertphillips@google.com>wrote:

> I was watching these Friday afternoon and came to the same conclusions.
>
>
> On Mon, Apr 30, 2012 at 2:09 PM, <tomhudson@google.com> wrote:
>
>> Just to follow up on the bench question: Mac might have gotten slightly
>> worse, Windows is OK, and Linux is too noisy to tell. Overall looks like
>> no problem.
>>
>>
http://codereview.appspot.com/**6135046/<http://codereview.appspot.com/6135046/>
>>
>
>  --
> You received this message because you are subscribed to the Google Groups
> "skia-review" group.
> To post to this group, send email to skia-review@googlegroups.com.
> To unsubscribe from this group, send email to
> skia-review+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/skia-review?hl=en.
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b