Issue 6135044: Clamp requested MSAA sample count to GL_MAX_SAMPLES

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6135044: Clamp requested MSAA sample count to GL_MAX_SAMPLES (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by bsalomon

Modified:
12 years, 7 months ago

Reviewers:
guanqun.lu, TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 2 : make sure GL_MAX_SAMPLES is legal before querying it #

Total comments: 4

Patch Set 3 : move sample count max to gl caps #

Patch Set 4 : revert GrDrawTarget.h #

Patch Set 5 : remove extra newline #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
M	src/gpu/gl/GrGLCaps.h	View	1 2 3 4	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1 2	3 chunks	+7 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

TomH

http://codereview.appspot.com/6135044/diff/2001/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): http://codereview.appspot.com/6135044/diff/2001/src/gpu/gl/GrGpuGL.cpp#newcode287 src/gpu/gl/GrGpuGL.cpp:287: // TODO: probe once at startup, rather than once ...

12 years, 7 months ago (2012-04-27 13:51:51 UTC) #2

bsalomon

12 years, 7 months ago (2012-04-27 14:15:16 UTC) #3

Closed r3777

Expand All Messages | Collapse All Messages