Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 6133061: [trunk] Copy TREE_STATIC() property from id in dwarf2asm.c

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by asharif
Modified:
12 years, 1 month ago
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/trunk/
Visibility:
Public.

Description

2012-05-31 Ahmad Sharif <asharif@google.com> * gcc/dwarf2asm.c: (dw2_output_indirect_constant_1): Copy TREE_STATIC() attribute from id to decl. Index: gcc/dwarf2asm.c =================================================================== --- gcc/dwarf2asm.c (revision 188089) +++ gcc/dwarf2asm.c (working copy) @@ -907,6 +907,7 @@ DECL_IGNORED_P (decl) = 1; DECL_INITIAL (decl) = decl; TREE_READONLY (decl) = 1; + TREE_STATIC (decl) = TREE_STATIC (id); if (TREE_PUBLIC (id)) { @@ -915,8 +916,6 @@ if (USE_LINKONCE_INDIRECT) DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN; } - else - TREE_STATIC (decl) = 1; sym_ref = gen_rtx_SYMBOL_REF (Pmode, sym); assemble_variable (decl, 1, 1, 1);

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M gcc/dwarf2asm.c View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
xur
Let's get this patch to google branch first. -Rong
12 years, 1 month ago (2012-05-31 23:18:40 UTC) #1
asharif
The relevant bug is this: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53546. Please take a look and provide feedback. Thanks,
12 years, 1 month ago (2012-06-01 00:10:16 UTC) #2
Diego Novillo
12 years, 1 month ago (2012-06-05 13:16:20 UTC) #3
On Thu, May 31, 2012 at 8:10 PM,  <asharif@chromium.org> wrote:
> Reviewers: xur, davidxl, iant2, Diego Novillo,
>
> Message:
> The relevant bug is this:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53546.

This bug does not affect trunk.  Only the google branches where LIPO
is implemented.


Diego.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b