delete unused code in SkStroke class

delete unused code in SkStroke class

Noticed that strokeLine is never used and other strokeXXX functions are not
even implemented. So I suggest to remove them.

BUG=
TEST=

[guanqun, 2012-05-02 03:03:21]

Please review. Thanks!

[reed1, 2012-05-02 12:13:47]

lets also move it into src/core, to make it private.

[guanqun, 2012-05-03 01:12:50]

On 2012/05/02 12:13:47, reed1 wrote:
> lets also move it into src/core, to make it private.

?? SkStroke.cpp file is already in src/core directory.

[reed1, 2012-05-03 12:15:38]

Sorry, I wasn't clear. Lets move SkStroke.h into src/core

[guanqun.lu_gmail.com, 2012-05-03 12:33:01]

SkStroke.h moved under src/core/ directory. Please review again.
Compiled successfully under Linux platform with float and fixed build.

On Thu, May 3, 2012 at 8:15 PM,  <reed@google.com> wrote:
> Sorry, I wasn't clear. Lets move SkStroke.h into src/core
>
> http://codereview.appspot.com/6131051/



-- 
Guanqun

[reed1, 2012-05-03 12:36:30]

lgtm

[guanqun.lu_gmail.com, 2012-05-03 12:54:53]

Hi Mike,

I have to ask you to help me land this CL, I don't have the
permission... Thanks!

On Thu, May 3, 2012 at 8:36 PM,  <reed@google.com> wrote:
> lgtm
>
> http://codereview.appspot.com/6131051/



-- 
Guanqun

[reed1, 2012-05-03 13:28:45]

patch does not cleanly apply. Can you try applying it yourself to a clean tree?


/cleanskia/trunk> patch -p0 < ~/Downloads/stroke.diff 
The next patch would delete the file a/include/core/SkStroke.h,
which does not exist!  Assume -R? [n] n

[epoger, 2012-05-03 14:03:37]

On 2012/05/03 13:28:45, reed1 wrote:
> patch does not cleanly apply. Can you try applying it yourself to a clean
tree?
> 
> 
> /cleanskia/trunk> patch -p0 < ~/Downloads/stroke.diff 
> The next patch would delete the file a/include/core/SkStroke.h,
> which does not exist!  Assume -R? [n] n

There are two problems here:

1. Guanqun uploaded this patch from a git checkout, so you have to run "patch
-p1" instead of "patch -p0", because git uses the a/blah vs b/blah convention
when generating a diff.

2. Even if you run "patch -p1", it still fails, because it deletes
include/core/SkStroke.h as its first action and then tries to do a rename from
include/core/SkStroke.h to src/core/SkStroke.h later on!  I think git must
handle the simultaneous rename/modification of a file differently than svn does.

I massaged the patch into svn in https://codereview.appspot.com/6181044 , and
committed it as https://code.google.com/p/skia/source/detail?r=3829 .  Hopefully
that will work OK, and you can close this code review.

[guanqun, 2012-05-03 14:06:06]

On 2012/05/03 13:28:45, reed1 wrote:
> patch does not cleanly apply. Can you try applying it yourself to a clean
tree?
> 
> 
> /cleanskia/trunk> patch -p0 < ~/Downloads/stroke.diff 

The problem is we should use '-p1' here.

But again, patch program can't read the 'rename' syntax in the diff, so it would
fail as well. If I'm using 'git apply stroke.diff', it would be OK, but then it
requires a git-svn setup.

I'm not sure hwo to disable the 'rename' syntax, I've tried different ways
locally to commit. It seems it's the configuration in the
codereview.appspot.com...

[guanqun, 2012-05-03 14:08:45]

On 2012/05/03 14:03:37, epoger wrote:
> I massaged the patch into svn in https://codereview.appspot.com/6181044 , and
> committed it as https://code.google.com/p/skia/source/detail?r=3829 . 
Hopefully
> that will work OK, and you can close this code review.

Oh, just saw your comments! I'll close this issue. Thanks for your efforts.