Issue 6127044: Give GrGLProgramStage a virtual destructor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6127044: Give GrGLProgramStage a virtual destructor (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by bsalomon

Modified:
12 years, 7 months ago

Reviewers:
robertphillips

CC:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Give GrGLProgramStage a virtual destructor

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/gpu/gl/GrGLProgramStage.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/gpu/gl/GrGLProgramStage.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2

bsalomon

Chromium's clang build gives a warning about delete being called on abstract class w/o a ...

12 years, 7 months ago (2012-04-25 17:46:41 UTC) #1

verbal lgtm from robertphillips@, committed r3767