Issue 6125046: Refactoring to begin encapsulating SW path rendering in GrPathRenderer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6125046: Refactoring to begin encapsulating SW path rendering in GrPathRenderer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by robertphillips

Modified:
12 years, 6 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

First pass at moving the software path rendering into a GrPathRenderer-derived class. I currently left the software rendering path in GrContext.cpp but will pull it into the GrSoftwarePathRenderer shell in a follow on delivery.

Patch Set 1 #

Patch Set 2 : Removed dead code & added comment #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -39 lines)			Patch
M	gyp/gpu.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrAddPathRenderers_default.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View		5 chunks	+59 lines, -39 lines	0 comments	Download
A	src/gpu/GrSoftwarePathRenderer.h	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	src/gpu/GrSoftwarePathRenderer.cpp	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

Committed first portion as r3769 Holding off on gpu.gyp & GrAddPathRenderers_default.cpp until can do the ...

12 years, 6 months ago (2012-04-27 12:10:13 UTC) #3

Committed second half as r3804

Expand All Messages | Collapse All Messages