Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 6118056: skdiff: if outputDir is not specified, don't write out diff files at all (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by epoger
Modified:
13 years, 1 month ago
Reviewers:
bsalomon, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

skdiff: if outputDir is not specified, don't write out diff files at all. Also adds list of files with pixel mismatch to the summary. Sometimes we don't need the diff images, just the summary. This will be useful for buildbots... we can run "gm -w" to generate actual images, and run comparisons in a separate skdiff step. BUG=http://code.google.com/p/skia/issues/detail?id=584

Patch Set 1 #

Patch Set 2 : fix line wraps #

Patch Set 3 : add num of pixel mismatches to summary report #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -26 lines) Patch
M tools/skdiff_main.cpp View 1 2 16 chunks +66 lines, -26 lines 0 comments Download

Messages

Total messages: 4
epoger
13 years, 1 month ago (2012-04-26 17:31:32 UTC) #1
bsalomon
On 2012/04/26 17:31:32, epoger wrote: LGTM
13 years, 1 month ago (2012-04-26 23:50:00 UTC) #2
TomH
Eh - this looks like the code I'd originally wrote, but Mike requested the two-dir ...
13 years, 1 month ago (2012-04-27 12:56:05 UTC) #3
epoger
13 years, 1 month ago (2012-04-27 15:55:32 UTC) #4
Closing in favor of https://codereview.appspot.com/6135045/ ('Add new flags to
skdiff')'
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b