Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1118)

Issue 6117051: Null canvas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by bsalomon
Modified:
12 years, 4 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Null canvas

Patch Set 1 #

Patch Set 2 : null canvas #

Patch Set 3 : move impl to cpp, move SkNullDevice out of public include dir #

Patch Set 4 : cleanup #

Patch Set 5 : update #

Patch Set 6 : update #

Total comments: 1

Patch Set 7 : use nway canvas #

Patch Set 8 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M gyp/utils.gyp View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
A include/utils/SkNullCanvas.h View 1 2 3 4 5 6 1 chunk +20 lines, -0 lines 0 comments Download
A src/utils/SkNullCanvas.cpp View 1 2 3 4 5 6 7 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6
bsalomon
We'll have to add the new cpp file to chrome's skia.gyp. Then we should be ...
12 years, 6 months ago (2012-04-24 21:31:56 UTC) #1
bsalomon
12 years, 6 months ago (2012-04-25 22:48:02 UTC) #2
reed1
http://codereview.appspot.com/6117051/diff/6007/include/utils/SkNullCanvas.h File include/utils/SkNullCanvas.h (right): http://codereview.appspot.com/6117051/diff/6007/include/utils/SkNullCanvas.h#newcode17 include/utils/SkNullCanvas.h:17: */ Do we need/want anything other than just width/height ...
12 years, 6 months ago (2012-04-26 01:00:11 UTC) #3
bsalomon
On 2012/04/26 01:00:11, reed1 wrote: > http://codereview.appspot.com/6117051/diff/6007/include/utils/SkNullCanvas.h > File include/utils/SkNullCanvas.h (right): > > http://codereview.appspot.com/6117051/diff/6007/include/utils/SkNullCanvas.h#newcode17 > ...
12 years, 6 months ago (2012-04-27 15:29:53 UTC) #4
bsalomon
Hey Mike can you take a look at the latest patch. I had forgotten about ...
12 years, 5 months ago (2012-06-11 12:21:36 UTC) #5
reed1
12 years, 5 months ago (2012-06-11 14:28:14 UTC) #6
Seems fine in general.

1. We might go through the formal exercise of documenting exactly how the APIs
on canvas will behave in this instance.

- drawFoo is easy, it returns void and does nothing, does not invoke Bounder or
DrawLooper

Do these return something meaningful?
- clipFoo
- getTotalClip
- getTotalMatrix

What does getDevice and createCompatibleDevice return?

What does setDevice do?
What does replayClips do?

Having said that, I'm fine to check this in now, so folks can use it, but we
should still document it at some point. LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b