Issue 6116047: minor refactoring to remove duplicate enum from Ganesh

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6116047: minor refactoring to remove duplicate enum from Ganesh (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by robertphillips

Modified:
12 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

minor refactoring to remove duplicate enum from Ganesh

Patch Set 1 #

Total comments: 1

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -72 lines)			Patch
M	include/gpu/GrClip.h	View	2 chunks	+9 lines, -9 lines	1 comment	Download
M	include/gpu/GrClipIterator.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	include/gpu/GrTypes.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	include/gpu/SkGr.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrClip.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	6 chunks	+17 lines, -17 lines	0 comments	Download
M	src/gpu/GrStencil.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/gpu/GrStencil.cpp	View	6 chunks	+11 lines, -11 lines	0 comments	Download
M	src/gpu/SkGr.cpp	View	1 chunk	+7 lines, -16 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

LGTM http://codereview.appspot.com/6116047/diff/1/include/gpu/GrClip.h File include/gpu/GrClip.h (left): http://codereview.appspot.com/6116047/diff/1/include/gpu/GrClip.h#oldcode63 include/gpu/GrClip.h:63: GrSetOp getOp(int i) const { return fList[i].fOp; } ...

12 years, 7 months ago (2012-04-25 15:14:30 UTC) #2

committed as r3763

Expand All Messages | Collapse All Messages