Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(361)

Issue 6109059: Removing deprecated classes/methods/fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by rmistry
Modified:
11 years, 11 months ago
Reviewers:
yanivi
Base URL:
https://google-http-java-client.googlecode.com/hg/
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing code review comments #

Total comments: 2

Patch Set 3 : Addressing code review comments #

Patch Set 4 : Minor fix #

Messages

Total messages: 5
rmistry
11 years, 11 months ago (2012-04-26 16:47:20 UTC) #1
yanivi
http://codereview.appspot.com/6109059/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java (right): http://codereview.appspot.com/6109059/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java#newcode336 google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java:336: boolean loggable = logger.isLoggable(Level.CONFIG) || logger.isLoggable(Level.ALL); boolean loggable = ...
11 years, 11 months ago (2012-04-26 17:48:27 UTC) #2
rmistry
http://codereview.appspot.com/6109059/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java (right): http://codereview.appspot.com/6109059/diff/1/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java#newcode336 google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java:336: boolean loggable = logger.isLoggable(Level.CONFIG) || logger.isLoggable(Level.ALL); On 2012/04/26 17:48:27, ...
11 years, 11 months ago (2012-04-26 17:57:40 UTC) #3
yanivi
LGTM http://codereview.appspot.com/6109059/diff/1008/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java (right): http://codereview.appspot.com/6109059/diff/1008/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java#newcode38 google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java:38: * Constructor that constructs a detail message from ...
11 years, 11 months ago (2012-04-26 18:11:33 UTC) #4
rmistry
11 years, 11 months ago (2012-04-26 18:19:37 UTC) #5
http://codereview.appspot.com/6109059/diff/1008/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java
(right):

http://codereview.appspot.com/6109059/diff/1008/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java:38:
* Constructor that constructs a detail message from the given HTTP response.
On 2012/04/26 18:11:33, yanivi wrote:
> I think it would be really helpful to specify that the detail message includes
> the status code, status message, and HTTP response content.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b